On Fri, 2020-01-03 at 20:42 +0100, Christof Warlich wrote: > By the way, I stumbled into a minor issue entirely unrelated to the > feature above that you may want to fix: The gnulib git repository > referenced in bootstrap seems to have changed its location, so you may > want it to change it accordingly:
Hm. Does the original not work? The version I have is the same one that is currently being distributed with the gnulib library; see: http://git.savannah.gnu.org/cgit/gnulib.git/tree/build-aux/bootstrap sv.gnu.org is a valid alias for savannah.gnu.org so unless the problem is with the git protocol vs. https, it should work fine. I would prefer to see this change made in gnulib's upstream copy if it is a correct change, rather than in my copy. > Furthermore, as running ./bootstrap adds the gnulib directory, it may be > appropriate to add it to .gitignore: OK. I always use a separate gnulib repo and set $GNULIB_SRCDIR, because checking out gnulib takes a long time. So I didn't notice this issue. > And finally, running ./bootstrap also changes lib/.gitignore and > m4/.gitignore, so you may want to consider to commit these changed > versions: I know about this but I don't want to do it. My setting for .gitignore is correct already. I really wish I could find a way to tell gnulib modules to stop messing around with my .gitignore files but until then I just don't pay any attention to those changes.