Am 12.06.2016 19:28, schrieb Eli Zaretskii (e...@gnu.org) [via 
dj...@delorie.com]:
Date: Sun, 12 Jun 2016 19:18:36 +0200
From: "Juan Manuel Guerrero (juan.guerr...@gmx.de) [via 
dj...@delorie.com]"<dj...@delorie.com>

     -  For systems like MSDOS, WINDOWS32 and other ones, the function 
get_bad_stdin
        is defined as a no-op macro in os.h but at the same time exists an
        implementation of the function in posixos.c.  This implementation
        is always compiled no matter if __MSDOS__ and/or MAKE_JOBSERVER is
        defined or not in posixos.c.  To avoid this contradiction, I have put
        the get_bad_stdin definition inside the same #ifdef than the ones used
        in os.h.  Please inspect the patch.  This approach is only a suggestion;
        may be there is a different way to solve this issue.

posixos.c is not supposed to be compiled on MSDOS (or any other
non-Posix system).  Why is it being compiled in the DJGPP build?

The other changes look fine to me, thanks.


Did not know this.  Because I never know how well maintained are the DJGPP
specific files like Makefile.DOS, etc I prefer to configure it by running
the configure script.  But this had produced a Makefile that had posixos
added to the list of object files thus making the build fail.  But if that
file is supposed not to used at all with non-Posix systems, please ignore
the proposed changes concerning posixos.c.  That is ok with me.


Regards,
Juan M. Guerrero

_______________________________________________
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make

Reply via email to