Follow-up Comment #14, bug #27809 (project make):
In its current state the CVS doesn't build for windows targets,
because the protoype for w32_kill isn't updated to match job.c.
I think Eli is aware of it but I am posting this so that things
do not get forgotten. And while I am here, here are some small
suggestions, see the attached new patch file w64-20100709.diff:
* job.c (pid2str): Do not limit %Id to gcc >= 4 because
gcc-3.4.5 from mingw.org understands %Id just fine, and the
__GNUC__ > 3 condition also eliminates the possibility of MSVC
compiler being in use.
(exec_command): Cast hWaitPID to pid_t which is what pid2str()
accepts, instead of DWORD_PTR.
* main.c (main, ADD_SIG): Pacify compiler.
* make.h: Move malloc.h include for WINDOWS32 to an earlier
place among the alloca ifdefs.
(w32_kill): Update prototype to match what is in job.c.
* w32/subproc/sub_proc.c: For MSVC, include stddef.h instead
of stdint.h for intptr_t.
* getopt.c (_getopt_initialize): Pacify compiler (unused argc
and argv) when not building for glibc.
(_getopt_internal): Add braces around if to avoid ambigous else.
[Note: the malloc.h include changes suggested for make.h won't
be necessary if the alloca ifdefs there goes back to the state
of make-3.81.]
(file #20931)
_______________________________________________________
Additional Item Attachment:
File name: w64-20100709.diff Size:4 KB
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?27809>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
Bug-make mailing list
Bug-make@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-make
