URL:
<http://savannah.gnu.org/bugs/?30323>
Summary: No path in MAKE_COMMAND (with fix)
Project: make
Submitted by: None
Submitted on: Fri 02 Jul 2010 12:53:59 PM UTC
Severity: 3 - Normal
Item Group: Bug
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
Component Version: CVS
Operating System: MS Windows
Fixed Release: None
Triage Status: None
_______________________________________________________
Details:
Hi,
The file main.c contains the following comment:
"Set the "MAKE_COMMAND" variable to the name we were invoked with. (If it is
a relative pathname with a slash, prepend our directory name so the result
will run the same program regardless of the current dir. If it is a name with
no slash, we can only hope that PATH did not find it in the current
directory.)"
However the last sentence isn't true for Windows. With
GetModuleFileName(NULL, ...) it is possible to reliably retrieve the absolute
pathname of the running program independently from the peculiarities of the
way it was called (aka the content of argv[0]).
The fix is to replace
if (strpbrk(argv[0], "/:\\") ||
strstr(argv[0], "..") ||
strneq(argv[0], "//", 2))
argv[0] = xstrdup(w32ify(argv[0],1));
with
argv[0] = xstrdup (w32ify (_pgmptr, 0));
This fix doesn't call GetModuleFileName() directly because that is documented
to require at least Windows 2000. Instead it uses _pgmptr which is documented
to be available since Windows 95 - and which is populated by the CRT nowadays
using GetModuleFileName().
Note that resolving to a full pathname in w32ify() is now turned off. It's
only called to convert '\' to '/'.
Oliver Schmidt - oliv.schmidt(at)sap.com
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?30323>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
Bug-make mailing list
Bug-make@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-make
