%% "Eli Zaretskii" <[EMAIL PROTECTED]> writes:

  ez> Thanks.  I downloaded that and built the DJGPP (a.k.a. MS-DOS)
  ez> port of this version of Make, and here are my findings.

Thanks Eli!  I haven't looked at the patches, but just a comment:

  ez> 5. On variable.c, the function define_automatic_variables used to
  ez>    always export SHELL (there was a line "v->export = v_export;" right
  ez>    after SHELL was assigned the default value), but now it doesn't.
  ez>    There's no ChangeLog entry corresponding to that change, so I
  ez>    couldn't grasp the reasons for it.  In any case, the DOS port needs
  ez>    SHELL to be exported, because otherwise the library function
  ez>    `system' doesn't see the value of SHELL modified by the Makefile,
  ez>    and doesn't DTRT for Makefile's whose commands require a Unixy
  ez>    shell.

The info on the new handling of SHELL is here (from the ChangeLog):

2004-11-28  Paul D. Smith  <[EMAIL PROTECTED]>

        * main.c (main) [WINDOWS32]: Remove any trailing slashes from -C
        arguments.  Fixes bug #10252.

        Fix for bug #1276: Handle SHELL according to POSIX requirements.

        * main.c (main): Set SHELL to v_noexport by default.  Remember the
        original environment setting of SHELL in the env_shell variable.
        * main.h: Export new env_shell variable.
        * variable.c (target_environment): If we find a v_noexport
        variable for SHELL, add a SHELL variable with the env_shell
        value.
        * doc/make.texi (Quick Reference): Document the POSIX behavior.
        * doc/make.texi (Variables/Recursion): Ditto.

We can special-case this for DOS, if necessary.  It should probably be
documented that way as well.

  ez> 8. The following file names cause trouble on 8+3 filesystems because
  ez>    they clash with other file names:

  ez>     tests/scripts/variables/MAKEFILE_LIST
  ez>     config/inttypes_h.m4
  ez>     config/inttypes-pri.m4

Hm.  Ouch.

Well, we can rename the MAKEFILE_LIST test without too much hassle.

Unfortunately, the other two are automatically installed by gettext,
and are standard files that are part of the gettext package.

Does the DOS port support gettext?  What happens when you unpack with
those filenames?

-- 
-------------------------------------------------------------------------------
 Paul D. Smith <[EMAIL PROTECTED]>          Find some GNU make tips at:
 http://www.gnu.org                      http://make.paulandlesley.org
 "Please remain calm...I may be mad, but I am a professional." --Mad Scientist


_______________________________________________
Bug-make mailing list
Bug-make@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-make

Reply via email to