On Wed, Apr 09, 2025 at 07:29:46PM -0700, Collin Funk wrote: > Hi Eric, > > I think it is worth applying this patch before you release m4. Without > it the tarball will likely fail to build due to linker errors on > platforms other than GNU/Linux.
Thanks; I'll apply parts of that soon. > > Also, while there, updating @INTL_MACOSX_LIBS@, per Bruno's > recommendations [1]. With the fix so 'make syntax-check' works. Here, I respectfully disagree with Bruno. Yes, we can silence the warning with a syntax-check exemption. But I'm convinced that we can leave it at $(INTL_MACOSX_LIBS) rather than the @@ form. Yes, the @@ form catches more typos, but we aren't making a typo. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org
