Am Mon, 30 Jan 2023 14:26:12 -0600 schrieb Eric Blake <ebl...@redhat.com>:
> On Sat, Jan 28, 2023 at 10:31:04PM +0100, Juan Manuel Guerrero wrote: > > I do not know if this issue has already been reported, but for all > > systems that distinguish between binary and text I/O, the file should > > be read in the same mode than it has been created or it may rise reading > > issues. When a "frozen" file is created in produce_frozen_state() this > > is done using binary mode and that is ok. But when it later is reloaded, > > the reading is done without specifying the mode and this defaults to > > text mode breaking/aborting the reading process. The patch below fixes > > the issue but it is only intended as suggestion. Fix the issue as you > > like. > > Thanks for the report. I'm not sure if calling SET_BINARY() is the > best fix, or if it is better to teach m4_path_search() which files > must be opened in binary mode (vs. in default mode, where the default > mode might be text on platforms where text is distinct from binary). > I'll give it some more thought, but may end up including your patch as > written if I can't think of anything more elegant. [snip] I agree. Please, fix it as you prefer. Regards, Juan M. Guerrero
