On 11/07/2014 09:08 AM, Daiki Ueno wrote: > Eric Blake <ebl...@redhat.com> writes: > >> [adding gnulib] >> >> On 11/06/2014 11:19 AM, Kiyoshi KANAZAWA wrote: >>> Hello, >>> >>> On Solaris 10 x86/x64, >>> "test-mbrtowc3.sh" fails if European localization is not installed. >>> It passes with European localization. > > I can reproduce it, and it seems to be the same issue as: > https://lists.gnu.org/archive/html/bug-gnulib/2014-10/msg00000.html > which I originally encountered on Solaris 11. > (It's curious that you could work it around by installing European > localization, while the test checks the mbrtowc behavior under Japanese > locale.) > > Perhaps it would be good to replace mbrtowc on Solaris, though I have no > idea how to detect the wrong behavior without depending on particular > locale data. Alternatively, we could simply ignore this test failure on > Solaris, since the tested calling convention is not very common.
I think it's better to declare the function broken and work around it than to just ignore it in the testsuite; but like you, I'm not sure how to easily expose the brokenness during a configure test, especially if someone is building a binary on a machine with a locale that "fixes" the issue but then wants to run the binary on another machine lacking the locale. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
