On 02/23/2011 02:33 PM, Ralf Wildenhues wrote: > * Ralf Wildenhues wrote on Wed, Feb 23, 2011 at 09:08:07PM CET: >> I can confirm the issue, but my bisect ended at >> 5e763da323f3927159b6c151f186569a9929ddbe instead.
Thankfully, 'git describe 5e763da' in m4.git states: v1.4.15-3-g5e763da That is, no released version of m4 has this commit (only m4 built from git). Unfortunately, you resolved to gnulib commit c823199d, which is not related to the bug uncovered this week. > memmem, strstr, strcasestr: fix bug with long periodic needle > > * lib/str-two-way.h (two_way_long_needle): Avoid bug with long > periodic needle having false positive. > * m4/memmem.m4 (gl_FUNC_MEMMEM_SIMPLE): Detect bug in glibc 2.12 > and cygwin 1.7.7. That fixed a false negative bug in strstr (ranging from gnulib c358da1e, 2008-01-10, to c823199d, 2010-10-05). But it didn't cover the false positive bug (ranging from fffd5fa, 2010-06-21, to 034c875, 2011-02-25). And that faulty commit was indeed present in 1.4.15. I'll be releasing 1.4.16 as soon as possible now. Thanks again for helping me get to the bottom of this, and apologies for breaking things there for a few months. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
