On 03/15/2010 09:20 AM, Bert Wesarg wrote: > Unset GIT_DIR and GIT_WORK_TREE environment variable in test > test-vc-list-files-git.sh. > > --- > diff --git i/tests/test-vc-list-files-git.sh w/tests/test-vc-list-files-git.sh > --- i/tests/test-vc-list-files-git.sh > +++ w/tests/test-vc-list-files-git.sh > @@ -28,6 +28,9 @@ tmpdir=vc-git-$$ > trap 'st=$?; cd '"`pwd`"' && rm -rf $tmpdir; exit $st' 0 > trap '(exit $?); exit $?' 1 2 13 15 > > +unset GIT_DIR > +unset GIT_WORK_TREE > + > fail=1 > mkdir $tmpdir && cd $tmpdir && > # without git, skip the test
Thanks for the patch. This needs to be flowed upstream to gnulib. Furthermore, some portability nits: If you want to be portable to bash 2.04, then you have to ensure that GIT_DIR and GIT_WORK_TREE are set (there, unset dumps core if used on variables that are not set). Also, this can be done in one unset instead of two: GIT_DIR= GIT_WORK_TREE=; unset GIT_DIR GIT_WORK_TREE -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
