-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Bruno Haible on 10/18/2008 3:37 PM:
>
> Thanks for this analysis. The sigset_t datatype introduced by gnulib has
> to be adjusted. I propose this patch. Eric, what do you think?
Generally looks okay to me.
> int
> sigfillset (sigset_t *set)
> {
> ! *set = ((2U << (NSIG - 1)) - 1)
> ! #ifdef SIGABRT_COMPAT
> ! & ~(1U << SIGABRT_COMPAT)
> ! #endif
> ! ;
However, I'm not the biggest fan of #ifdef inside a statement. Maybe a
helper macro would make this read a bit cleaner:
#ifdef SIGABRT_COMPAT
# define SIGFILLMASK (~(1U << SIGABRT_COMPAT))
#else
# define SIGFILLMASK (~0U)
#endif
int
sigfillset (sigset_t *set)
{
*set = ((2U << (NSIG - 1)) - 1) & SIGFILLMASK;
return 0;
}
- --
Don't work too hard, make some time for fun as well!
Eric Blake [EMAIL PROTECTED]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkj8bz8ACgkQ84KuGfSFAYBPOQCglTUcA1NV/k9UqVrO25cbqrQN
+aEAnReEPEmsvkD4kHXVzdZf+45da7e2
=6/kE
-----END PGP SIGNATURE-----
