Am So., 30. Sep. 2018 um 15:59 Uhr schrieb David Kastrup <d...@gnu.org>:
> Tracker issue: 5422 (https://sourceforge.net/p/testlilyissues/issues/5422/) > Rietveld issue: 345090043 (https://codereview.appspot.com/345090043) > Issue description: > Escape nul, cr, newline in PDF metadata > > I wasn't really aware that the strings remain pure 8-bit strings on > input and the UTF16 interpretation is private business of the pdfmark > command. So thanks for that pointer, allowing to tackle this fairly > long-known bug. Hi David, I tested your patch with a .ly-file containing \header { title = "fooüČč" } checking meta-data with exiftool. With 2.19.82: Title : foo�Čč Recent master: Title : fooüČč Recent master with guile-2.0.14 and the patches from branch guile-v2-work: Title : fooüČč Recent master with guile-2.2.4 and the patches from branch guile-v2-work and some others: Title : ??foo?.... Looks like a change in guile-2.2.x, so ly:encode-string-for-pdf does not work as before. But enabling the commented code in 'handle-metadata', i.e.: (use-modules (ice-9 iconv)) (use-modules (rnrs bytevectors)) ;;; Create DOCINFO pdfmark containing metadata ;;; header fields with pdf prefix override those without the prefix (define (handle-metadata header port) (define (metadata-encode val) ;; First, call ly:encode-string-for-pdf to encode the string (latin1 or ;; utf-16be), then escape all parentheses and backslashes ;; ;; NOTE: with guile-2.0+ ly:encode-string-for-pdf is not really needed and ;; could be replaced. ;; For guile-2.2.+ this is a 'must do' ;; (ps-quote (let* ((utf16be-bom #vu8(#xFE #xFF))) (string-append (bytevector->string utf16be-bom "ISO-8859-1") (bytevector->string (string->utf16 val 'big) "ISO-8859-1"))))) ...) Returns Title : fooüČč as desired. I tried to create something like below with a guile-v2-condition: (use-modules (ice-9 iconv)) (use-modules (rnrs bytevectors)) ;;; Create DOCINFO pdfmark containing metadata ;;; header fields with pdf prefix override those without the prefix (define (handle-metadata header port) (define (metadata-encode val) ;; First, call ly:encode-string-for-pdf to encode the string (latin1 or ;; utf-16be), then escape all parentheses and backslashes ;; ;; NOTE: with guile-2.0+ ly:encode-string-for-pdf is not really needed and ;; could be replaced. ;; For guile-2.2.+ this is a 'must do' ;; (ps-quote (if guile-v2 (let* ((utf16be-bom #vu8(#xFE #xFF))) (string-append (bytevector->string utf16be-bom "ISO-8859-1") (bytevector->string (string->utf16 val 'big) "ISO-8859-1"))) (ly:encode-string-for-pdf val)))) ...) Though, this does not work, because guile-1.8 would issue an error about the unknown syntax. Any chance to create something which will work in guilev1 and guilev2? Cheers, Harm _______________________________________________ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
