Comment #7 on issue 854 by percival.music.ca: lilycontrib.tcl
http://code.google.com/p/lilypond/issues/detail?id=854
BTW, does anybody other than Carl feel like taking it over? Mark,
maybe? :)
I think version 0.5 is actually a step back from the previous one (where it
just had
a check-box for 'translator or not'). I propose:
- have a variable at the top of the script; IS_TRANSLATOR = 0 / 1 (or
true/false,
or whatever the format of this language is).
- we distribute two versions of the script; one for translators, one for
normal
contributors. The only difference between the two scripts is that single
global
variable at the top of the script. Yes, this means that we "waste" 6.7 Kb
of web
hosting space. Cry me a river.
- inside the script, instead of having:
button .buttons.patch -text "Make patch from origin" -command
patch_from_origin
button .buttons.patch_translation -text "Make translation patch from
origin" -co
we have:
if (IS_TRANSLATOR)
button .buttons.patch_translation -text "Make translation patch from
origin" -co
else
button .buttons.patch -text "Make patch from origin" -command
patch_from_origin
endif
(or whatever the syntax is)
Now some nitpicks:
- can the commit/abort/etc buttons be greyed-out if the user hasn't
initialized yet?
- if/when the split between normal+translation is done, could the update
button just
be "initalize code" or "update code" ? I think short+sweet is better.
- generally, catch errors: for example, clicking "locally commit changes"
when no
changes are done will pop up a window saying "git aborted: child process
exited
abnormally".
- after a few random clicks, attempting to "abort changes - revert to
origin" (the
panic button" produces:
abort_dir: ./aborted_edits
fatal: unable to create '/home/gperciva/lilypond/.git/index.lock': File
exists
fatal: Could not reset index file to revision 'origin/master'.
Repository reset.
that's highly sub-optimal; the "nuke them all from orbit, it's the only
way to be
sure" button should always work.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
_______________________________________________
bug-lilypond mailing list
bug-lilypond@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-lilypond
