Zhaoming Luo, le dim. 23 mars 2025 13:29:47 +0800, a ecrit:
> On Sun, Mar 23, 2025 at 12:48:52AM +0100, Samuel Thibault wrote:
> > Zhaoming Luo, le sam. 22 mars 2025 15:24:50 +0800, a ecrit:
> > 
> > > diff --git a/i386/i386at/model_dep.c b/i386/i386at/model_dep.c
> > > index 30449c37..aa8451ac 100644
> > > --- a/i386/i386at/model_dep.c
> > > +++ b/i386/i386at/model_dep.c
> > > @@ -229,6 +229,11 @@ void machine_init(void)
> > >    */
> > >   hpet_init();
> > >  #endif
> > > +
> > > + /*
> > > +  * Initialize the HPET
> > > +  */
> > > + hpet_init();
> > >  }
> > >  
> > >  /* Conserve power on processor CPU.  */
> > 
> > You should also cope with the case where hpet_addr is NULL.
> > 
> Is this `assert(hpet_addr != 0)` a kind of cope?
> 
> https://git.savannah.gnu.org/cgit/hurd/gnumach.git/tree/i386/i386/apic.c#n426

No, I meant: the machine could have no HPET, better just disable the
tuning in that case.

Samuel

Reply via email to