Hi! On Sat, 2025-02-22 at 15:33:47 +0100, Samuel Thibault wrote: > Samuel Thibault, le sam. 22 févr. 2025 15:33:27 +0100, a ecrit: > > Guillem Jover, le sam. 22 févr. 2025 14:09:59 +0100, a ecrit: > > > The pciutils package is failing to build in Debian on hurd-amd64: > > > > > > > > > https://buildd.debian.org/status/fetch.php?pkg=pciutils&arch=hurd-amd64&ver=1%3A3.13.0-1%2Bb1&stamp=1732538417&raw=0 > > > > > > The error is the following: > > > > > > ,--- > > > 315 | int err = pci_get_dev_rom(device_port, &buf, &size); > > > | ^~~~~ > > > | | > > > | size_t * {aka long > > > unsigned int *} > > > /usr/include/hurd/pci.h:174:33: note: expected ‘mach_msg_type_number_t *’ > > > {aka ‘unsigned int *’} but argument is of type ‘size_t *’ {aka ‘long > > > unsigned int *’} > > > 174 | mach_msg_type_number_t *dataCnt > > > `--- > > > > > > And the function on hurd/pci-arbiter/pci-ops.c, seems to confirm this. > > > Where I think datalen should probably be a data type equivalent to > > > size_t's length (instead of it being just a natural_t)? > > > > We can't really change the mach_msg_type_number_t type without > > rebootstraping everything. > > pciutils has to be fixed into using mach_msg_type_number_t anyway.
Ah, sorry, I just saw that you had already fixed this upstream back in November in commit 4f2abadf015dd730d9c42a10ca5db6ed3bd6b9d2! Will cherry-pick that for the Debian packages. Thanks, Guillem
