On Sun, Dec 8, 2024 at 11:54 AM Zhaoming Luo <zhming...@163.com> wrote: > > Reviewed-by: Sergey Bugaev <buga...@gmail.com> > > > Thanks for the review. > > (...but I don't know exactly what you're supposed to do with that R-b > > line. I asked on libc-alpha last year [0], and didn't get a reply.) > > [0]: https://sourceware.org/pipermail/libc-alpha/2023-June/149094.html > What do you mean by R-b line? Does that refer to the patches I submitted > for the rtc translator?
I mean the "Reviewed-by" line. (And no, I was talking about this very patch, not the RTC ones.) You can find some docs about it at [0][1][2], [0]: https://git-scm.com/docs/SubmittingPatches#sign-off [1]: https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes [2]: https://www.x.org/wiki/Development/Documentation/SubmittingPatches/ but basically the idea is that once someone (in this case, me) has reviewed a patch and agrees with it, they can "offer" a "Reviewed-by: That Person <t...@example.com>" line to the patch author, just like I did above. Frequently a reviewer would actually point out some small changes to be made in the patch, and then say something like: "With those changes, Reviewed-by: ... <...@example.com>", meaning the R-b line is valid if the patch author accepts the proposed changes to their patch. The Reviewed-by line(s) offered by the reviewer(s) is supposed to end up in subsequent iterations of the patch (unless the patch gets changed substantially?) and in the Git commit once the patch is pushed, right next to other "trailers" like Signed-off-by and Suggested-by. What's unclear to me is exactly how this is supposed to work. Well, in this specific case, assuming this will be the only iteration of the patch, let's hope Samuel notices this thread :) and appends my R-b line to your commit message, but I don't understand how this is supposed to work in general. Sergey
