I agree with you, I mentioned that this was the "minimal effort" patchset to get qemu compilable.
On Wed, Jan 17, 2024 at 6:35 PM Peter Maydell <peter.mayd...@linaro.org> wrote: [...] > should be guarded by a suitable check that means we don't > try to build it on hosts that don't have the host-specific > functions/whatever that it needs. This is the best solution for this problem, any pointers on how to best do this? Thanks On Wed, Jan 17, 2024 at 6:35 PM Peter Maydell <peter.mayd...@linaro.org> wrote: > > On Wed, 17 Jan 2024 at 12:59, Manolo de Medici <manolodemed...@gmail.com> > wrote: > > > > tests/qtest/tpm-* compilation is not disabled by disable-tpm, > > for this reason compilation fails on systems that doesn't > > support the linux/bsd TPM api. Fix this by allowing tests > > to be disabled. > > This isn't the right way to fix this. Either the tpm test > code has portability issues that can be fixed, or else it > should be guarded by a suitable check that means we don't > try to build it on hosts that don't have the host-specific > functions/whatever that it needs. > > thanks > -- PMM
