Sergey Bugaev, le dim. 19 mars 2023 18:39:20 +0300, a ecrit: > Yay! Can you believe just how glad I am to finally have completed it :D
I think I do :) > > I don't have the time now to review the whole series, just a comment > > here: we don't really want to introduce abilist for lib{mach,hurd}user > > since their content will depend on the mach/hurd version glibc gets > > built against. > > But isn't accidental ABI breakage (or unintended ABI additions) > exactly what the abilist mechanism is designed to guard against? Yes, but glibc is not responsible for ABI breakage of hurd and mach interfaces, so it's not really responsible for testing them. > It doesn't even break your build (unlike -Werror) -- it's more of a > lint. ? I believe it does? > Well in any case, the abilists aren't essential. Freel free to drop > this commit (and remove lib{mach,hurd}user.abilist from the next one) > if that was the wrong call. Sure! Samuel