On Fri, Feb 17, 2023 at 6:26 AM Sergey Bugaev <buga...@gmail.com> wrote:
> On Fri, Feb 17, 2023 at 9:02 AM Flávio Cruz <flavioc...@gmail.com> wrote: > > Thanks for the instructions. I discovered that mach_msg_type_long_t does > not align to 8 bytes so it also needs a bit of padding just like > mach_msg_type_t. See my last patch. I was able to compile most of the glibc > and all the stubs after this change. > > That worked like a charm, thank you! > > with desired_complex_alignof manually set to 8, that is. Right now it > is set to sizeof(natural_t) -- i.e. 4. Should we change it to > alignof(uintptr_t) or something like that? > Yes, I just sent two patches to do that. As a bonus, we also ensure the 64 bit kernel is free of undefined behavior when built for a 32 bit userland. > Sergey >