[PATCH 11/17] ext2fs: resolve a todo, check writability before writing

[Etienne Brateau]

---
 ext2fs/hyper.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ext2fs/hyper.c b/ext2fs/hyper.c
index 65a2937e..9bff609f 100644
--- a/ext2fs/hyper.c
+++ b/ext2fs/hyper.c
@@ -199,6 +199,9 @@ diskfs_set_hypermetadata (int wait, int clean)
 
   if (sblock_dirty)
    {
+     if (diskfs_readonly)
+       return EROFS; /* impossible to write */
+
      /* Before writing, set the time of write */
      sblock->s_wtime = htole32(diskfs_mtime->seconds);
      sblock_dirty = 0;
@@ -209,7 +212,6 @@ diskfs_set_hypermetadata (int wait, int clean)
 
   sync_global (wait);
 
-  /* Should check writability here and return EROFS if necessary. XXX */
   return 0;
 }
 
-- 
2.34.1