Samuel Thibault, le dim. 09 janv. 2022 13:14:21 +0100, a ecrit: > Joan Lledó, le dim. 09 janv. 2022 12:16:21 +0100, a ecrit: > > > > El 9/1/22 a les 1:15, Samuel Thibault ha escrit: > > > > Err, this is breaking everything when pci-arbiter is not running as a > > > > bootstrap translator. In that case e.g. netdde succeeds getting the > > > > privileged port, and thus tries to open pci, but fails, and thus the > > > > whole thing aborts. What problem the older approach had? > > > > > > I uploaded a version with that ordering fixed back to debian-ports, to > > > be seen on mirrors within about 6h. > > > > That was because I wanted to allow non-root users to install nested > > arbiters. Non-root users can't pass this condition: > > > > https://gitlab.freedesktop.org/xorg/lib/libpciaccess/-/blob/master/src/hurd_pci.c#L640 > > Then rearrange the conditions to avoid returning when that fails. But > still revert back to file_name_lookup even if that succeeds.
And most importantly, please do not hide such change in a commit that has a completely unrelated subject. Samuel
