On 7/3/21 9:25 pm, Samuel Thibault wrote: > Damien Zammit, le dim. 07 mars 2021 17:39:04 +1100, a ecrit: >> [PATCH 3/6] libnetfs: Hacks to allow pci to run with no cred >> >> This is still needed to bypass the cred uid=0. >> I tried to call fsys_getroot, but it failed/hung when running it >> at the point where I needed the root port. > > Where is that point?
As soon as fsys_startup returns in pcifs_startup, it returns a realnode == MACH_PORT_NULL. Ideally, I need to call fsys_getroot right then and return from pcifs_startup with an actual protid to the pci root. But if I do this, it hangs. (I think it doesn't have a auth or proc server available). >> Can we live with this patch for now? > > No, !dircred can come from various cases, like the passed port name > being bogus or for an improper class etc. Basically you'd give to > anybody malignant enough root access to all libnetfs translators. Ok, this is a problem that I don't know how to solve. Damien