I fixed the problem manually. I expect the patch works fine. El mar., 11 ago. 2020 a las 23:24, Almudena Garcia (< liberamenso10...@gmail.com>) escribió:
> oops!! I forgot add i386/i386/smp.h and i386/i386/smp.c to i386/Makefrag.am > > I will try to fix the patch to add this > > El mar., 11 ago. 2020 a las 23:03, Almudena Garcia (< > liberamenso10...@gmail.com>) escribió: > >> I attach a new set of patches. I wait this time will be better than last >> time >> >> El mar., 11 ago. 2020 a las 2:27, Almudena Garcia (< >> liberamenso10...@gmail.com>) escribió: >> >>> > So don't bring them online then? The user asked for 4 CPUs, so bring up >>> > 3 APs alongside the BSP and that's that. >>> It's not a bad idea. Then I will fix my cpu enumeration loop to add this >>> new condition. >>> >>> El mar., 11 ago. 2020 a las 2:23, Jessica Clarke (<jrt...@jrtc27.com>) >>> escribió: >>> >>>> On 11 Aug 2020, at 01:17, Almudena Garcia <liberamenso10...@gmail.com> >>>> wrote: >>>> > >>>> > > That being said, instead of hardcoding the maximum number of CPUs to >>>> > > be 256, you can just let the user choose whatever value is >>>> preferred. >>>> > > That's what Linux does. >>>> > >>>> > But this could cause coherency problems. >>>> >>>> Coherency is a very specific thing in operating systems about the >>>> properties of the underlying memory subsystem. It's not the word you're >>>> looking for. >>>> >>>> > By example, if the user sets mach_ncpus=4 , and the processor has 8 >>>> cores, It can produce an out-of-index error in the access to the arrays >>>> which store the info about the cpus. >>>> >>>> So don't bring them online then? The user asked for 4 CPUs, so bring up >>>> 3 APs alongside the BSP and that's that. >>>> >>>> Jess >>>> >>>>
From 79240dbb2267744655797607919f75f79f30c88c Mon Sep 17 00:00:00 2001 From: Almudena Garcia <liberamenso10...@gmail.com> Date: Tue, 11 Aug 2020 22:07:39 +0200 Subject: [PATCH 1/5] smp: Add pseudoclass to manage APIC operations The SMP support requires access, register and configure some APIC structures, like Local APIC and IOAPIC. This pseudoclass includes functions to register some APIC structures into the kernel, and access to these structures to extract some information. *apic.h: Header file recovered from Mach 4 source code, and updated for xAPIC. Includes some structs with Local APIC and IOAPIC fields, and the declaration of the functions. *apic.c: Source file. Includes the definition of the functions, within some globals of apic_info structures and the lapic reference. --- i386/Makefrag.am | 4 +- i386/i386/apic.c | 223 +++++++++++++++++++++++++++++++++++++++++++++++ i386/i386/apic.h | 139 +++++++++++++++++++++++++++++ 3 files changed, 365 insertions(+), 1 deletion(-) create mode 100644 i386/i386/apic.c create mode 100644 i386/i386/apic.h diff --git a/i386/Makefrag.am b/i386/Makefrag.am index b2b4f77f..b45378fd 100644 --- a/i386/Makefrag.am +++ b/i386/Makefrag.am @@ -160,7 +160,9 @@ libkernel_a_SOURCES += \ i386/i386/pic.c \ i386/i386/pic.h \ i386/i386/pit.c \ - i386/i386/pit.h + i386/i386/pit.h \ + i386/i386/apic.h \ + i386/i386/apic.c endif # diff --git a/i386/i386/apic.c b/i386/i386/apic.c new file mode 100644 index 00000000..ccba3857 --- /dev/null +++ b/i386/i386/apic.c @@ -0,0 +1,223 @@ +/* apic.c - APIC controller management for Mach. + Copyright (C) 2020 Free Software Foundation, Inc. + Written by Almudena Garcia Jurado-Centurion + + This file is part of GNU Mach. + + GNU Mach is free software; you can redistribute it and/or modify it + under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2, or (at your option) + any later version. + + GNU Mach is distributed in the hope that it will be useful, but + WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, write to the Free Software + Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111, USA. */ + +#include <i386/apic.h> +#include <string.h> +#include <vm/vm_kern.h> +#include <kern/printf.h> +#include <kern/kalloc.h> + + +volatile ApicLocalUnit* lapic = NULL; + +ApicInfo apic_data; + +/* + * apic_data_init: initialize the apic_data structures to preliminary values. + * Reserve memory to the lapic list dynamic vector. + * Returns 0 if success, -1 if error. + */ +int +apic_data_init(void) +{ + apic_data.cpu_lapic_list = NULL; + apic_data.ncpus = 0; + apic_data.nioapics = 0; + apic_data.nirqoverride = 0; + + /* Reserve the vector memory for the maximum number of processors. */ + apic_data.cpu_lapic_list = (uint16_t*) kalloc(NCPUS*sizeof(uint16_t)); + + /* If the memory reserve fails, return -1 to advice about the error. */ + if (apic_data.cpu_lapic_list == NULL) + return -1; + + return 0; +} + +/* + * apic_lapic_init: initialize lapic pointer to the memory common address. + * Receives as input a pointer to the virtual memory address, previously mapped in a page. + */ +void +apic_lapic_init(ApicLocalUnit* lapic_ptr) +{ + lapic = lapic_ptr; +} + +/* + * apic_add_cpu: add a new lapic/cpu entry to the cpu_lapic list. + * Receives as input the lapic's APIC ID. + */ +void +apic_add_cpu(uint16_t apic_id) +{ + apic_data.cpu_lapic_list[apic_data.ncpus] = apic_id; + apic_data.ncpus++; +} + +/* + * apic_add_ioapic: add a new ioapic entry to the ioapic list. + * Receives as input an ioapic_data structure, filled with the IOAPIC entry's data. + */ +void +apic_add_ioapic(IoApicData ioapic) +{ + apic_data.ioapic_list[apic_data.nioapics] = ioapic; + apic_data.nioapics++; +} + +/* + * apic_add_irq_override: add a new IRQ to the irq_override list. + * Receives as input an irq_override_data structure, filled with the IRQ entry's data. + */ +void +apic_add_irq_override(IrqOverrideData irq_over) +{ + apic_data.irq_override_list[apic_data.nirqoverride] = irq_over; + apic_data.nirqoverride++; +} + +/* + * apic_get_cpu_apic_id: returns the apic_id of a cpu. + * Receives as input the kernel ID of a CPU. + */ +uint16_t +apic_get_cpu_apic_id(int kernel_id) +{ + if (kernel_id >= NCPUS) + return -1; + + return apic_data.cpu_lapic_list[kernel_id]; +} + +/* apic_get_lapic: returns a reference to the common memory address for Local APIC. */ +volatile ApicLocalUnit* +apic_get_lapic(void) +{ + return lapic; +} + +/* + * apic_get_ioapic: returns the IOAPIC identified by its kernel ID. + * Receives as input the IOAPIC's Kernel ID. + * Returns a ioapic_data structure with the IOAPIC's data. + */ +struct IoApicData +apic_get_ioapic(int kernel_id) +{ + IoApicData io_apic = {}; + + if (kernel_id < MAX_IOAPICS) + return apic_data.ioapic_list[kernel_id]; + return io_apic; +} + +/* apic_get_numcpus: returns the current number of cpus. */ +uint8_t +apic_get_numcpus(void) +{ + return apic_data.ncpus; +} + +/* apic_get_num_ioapics: returns the current number of ioapics. */ +uint8_t +apic_get_num_ioapics(void) +{ + return apic_data.nioapics; +} + +/* + * apic_get_current_cpu: returns the apic_id of current cpu. + */ +uint16_t +apic_get_current_cpu(void) +{ + uint16_t apic_id; + + if(lapic == NULL) + apic_id = 0; + else + apic_id = lapic->apic_id.r; + + return apic_id; +} + + +/* + * apic_refit_cpulist: adjust the size of cpu_lapic array to fit the real number of cpus + * instead the maximum number. + * + * Returns 0 if success, -1 if error. + */ +int apic_refit_cpulist(void) +{ + uint16_t* old_list = apic_data.cpu_lapic_list; + uint16_t* new_list = NULL; + + if (old_list == NULL) + return -1; + + if(apic_data.ncpus < NCPUS) { + new_list = (uint16_t*) kalloc(apic_data.ncpus*sizeof(uint16_t)); + + if (new_list == NULL) + return -1; + + for (int i = 0; i < apic_data.ncpus; i++) + new_list[i] = old_list[i]; + + apic_data.cpu_lapic_list = new_list; + kfree((vm_offset_t) old_list, NCPUS*sizeof(uint16_t)); + } + + return 0; +} + +/* + * apic_print_info: shows the list of Local APIC and IOAPIC. + * Shows each CPU and IOAPIC, with Its Kernel ID and APIC ID. + */ +void apic_print_info(void) +{ + int i; + int ncpus, nioapics; + + ncpus = apic_get_numcpus(); + nioapics = apic_get_num_ioapics(); + + uint16_t lapic_id; + uint16_t ioapic_id; + + IoApicData ioapic; + + printf("CPUS:\n"); + for (i = 0; i < ncpus; i++) { + lapic_id = apic_get_cpu_apic_id(i); + printf(" CPU %d - APIC ID %x\n", i, lapic_id); + } + + printf("IOAPICS:\n"); + for (i = 0; i < nioapics; i++) { + ioapic = apic_get_ioapic(i); + ioapic_id = ioapic.apic_id; + printf(" IOAPIC %d - APIC ID %x\n", i, ioapic_id); + } +} diff --git a/i386/i386/apic.h b/i386/i386/apic.h new file mode 100644 index 00000000..e2d2c508 --- /dev/null +++ b/i386/i386/apic.h @@ -0,0 +1,139 @@ +/* + * Copyright (c) 1994 The University of Utah and + * the Computer Systems Laboratory at the University of Utah (CSL). + * All rights reserved. + * + * Permission to use, copy, modify and distribute this software is hereby + * granted provided that (1) source code retains these copyright, permission, + * and disclaimer notices, and (2) redistributions including binaries + * reproduce the notices in supporting documentation, and (3) all advertising + * materials mentioning features or use of this software display the following + * acknowledgement: ``This product includes software developed by the + * Computer Systems Laboratory at the University of Utah.'' + * + * THE UNIVERSITY OF UTAH AND CSL ALLOW FREE USE OF THIS SOFTWARE IN ITS "AS + * IS" CONDITION. THE UNIVERSITY OF UTAH AND CSL DISCLAIM ANY LIABILITY OF + * ANY KIND FOR ANY DAMAGES WHATSOEVER RESULTING FROM THE USE OF THIS SOFTWARE. + * + * CSL requests users of this software to return to csl-d...@cs.utah.edu any + * improvements that they make and grant CSL redistribution rights. + * + * Author: Bryan Ford, University of Utah CSL + */ +#ifndef _IMPS_APIC_ +#define _IMPS_APIC_ + +#ifndef __ASSEMBLER__ + +#include <stdint.h> + +typedef struct ApicReg { + unsigned r; /* the actual register */ + unsigned p[3]; /* pad to the next 128-bit boundary */ +} ApicReg; + +typedef struct ApicIoUnit { + ApicReg select; + ApicReg window; +} ApicIoUnit; + + +typedef struct ApicLocalUnit { + ApicReg reserved0; /* 0x000 */ + ApicReg reserved1; /* 0x010 */ + ApicReg apic_id; /* 0x020 */ + ApicReg version; /* 0x030 */ + ApicReg reserved4; /* 0x040 */ + ApicReg reserved5; /* 0x050 */ + ApicReg reserved6; /* 0x060 */ + ApicReg reserved7; /* 0x070 */ + ApicReg task_pri; /* 0x080 */ + ApicReg arbitration_pri; /* 0x090 */ + ApicReg processor_pri; /* 0x0a0 */ + ApicReg eoi; /* 0x0b0 */ + ApicReg remote; /* 0x0c0 */ + ApicReg logical_dest; /* 0x0d0 */ + ApicReg dest_format; /* 0x0e0 */ + ApicReg spurious_vector; /* 0x0f0 */ + ApicReg isr[8]; /* 0x100 */ + ApicReg tmr[8]; /* 0x180 */ + ApicReg irr[8]; /* 0x200 */ + ApicReg error_status; /* 0x280 */ + ApicReg reserved28[6]; /* 0x290 */ + ApicReg lvt_cmci; /* 0x2f0 */ + ApicReg icr_low; /* 0x300 */ + ApicReg icr_high; /* 0x310 */ + ApicReg lvt_timer; /* 0x320 */ + ApicReg lvt_thermal; /* 0x330 */ + ApicReg lvt_performance_monitor; /* 0x340 */ + ApicReg lvt_lint0; /* 0x350 */ + ApicReg lvt_lint1; /* 0x360 */ + ApicReg lvt_error; /* 0x370 */ + ApicReg init_count; /* 0x380 */ + ApicReg cur_count; /* 0x390 */ + ApicReg reserved3a; /* 0x3a0 */ + ApicReg reserved3b; /* 0x3b0 */ + ApicReg reserved3c; /* 0x3c0 */ + ApicReg reserved3d; /* 0x3d0 */ + ApicReg divider_config; /* 0x3e0 */ + ApicReg reserved3f; /* 0x3f0 */ +} ApicLocalUnit; + +typedef struct IoApicData { + uint8_t apic_id; + uint32_t addr; + uint32_t base; +} IoApicData; + +#define APIC_IRQ_OVERRIDE_ACTIVE_LOW 2 +#define APIC_IRQ_OVERRIDE_LEVEL_TRIGGERED 8 + +typedef struct IrqOverrideData { + uint8_t bus; + uint8_t irq; + uint32_t gsi; + uint16_t flags; +} IrqOverrideData; + +#define MAX_IOAPICS 16 +#define MAX_IRQ_OVERRIDE 24 + +typedef struct ApicInfo { + uint8_t ncpus; + uint8_t nioapics; + int nirqoverride; + uint16_t* cpu_lapic_list; + struct IoApicData ioapic_list[MAX_IOAPICS]; + struct IrqOverrideData irq_override_list[MAX_IRQ_OVERRIDE]; +} ApicInfo; + +int apic_data_init(void); +void apic_add_cpu(uint16_t apic_id); +void apic_lapic_init(ApicLocalUnit* lapic_ptr); +void apic_add_ioapic(struct IoApicData); +void apic_add_irq_override(struct IrqOverrideData irq_over); +uint16_t apic_get_cpu_apic_id(int kernel_id); +volatile ApicLocalUnit* apic_get_lapic(void); +struct IoApicData apic_get_ioapic(int kernel_id); +uint8_t apic_get_numcpus(void); +uint8_t apic_get_num_ioapics(void); +uint16_t apic_get_current_cpu(void); +void apic_print_info(void); +int apic_refit_cpulist(void); + +#endif + +#define APIC_IO_UNIT_ID 0x00 +#define APIC_IO_VERSION 0x01 +#define APIC_IO_REDIR_LOW(int_pin) (0x10+(int_pin)*2) +#define APIC_IO_REDIR_HIGH(int_pin) (0x11+(int_pin)*2) + +/* Set or clear a bit in a 255-bit APIC mask register. + These registers are spread through eight 32-bit registers. */ +#define APIC_SET_MASK_BIT(reg, bit) \ + ((reg)[(bit) >> 5].r |= 1 << ((bit) & 0x1f)) +#define APIC_CLEAR_MASK_BIT(reg, bit) \ + ((reg)[(bit) >> 5].r &= ~(1 << ((bit) & 0x1f))) + +#endif /*_IMPS_APIC_*/ + -- 2.28.0
From 2ef268aa3d175bb0c99ea3c65ed51d26ef1b1f86 Mon Sep 17 00:00:00 2001 From: Almudena Garcia <liberamenso10...@gmail.com> Date: Tue, 11 Aug 2020 22:16:45 +0200 Subject: [PATCH 3/5] smp: Add APIC finder and parser To find the processors, It's necessary to find the APIC (MADT) table This table is found inside ACPI tables. This set of functions find the MADT table, and parse it to find the APIC structures and register it in the kernel. *acpi_parse_apic.h: ACPI structures and function prototypes. *acpi_parse_apic.c: ACPI/APIC function definitions. --- i386/Makefrag.am | 4 +- i386/i386at/acpi_parse_apic.c | 542 ++++++++++++++++++++++++++++++++++ i386/i386at/acpi_parse_apic.h | 164 ++++++++++ 3 files changed, 709 insertions(+), 1 deletion(-) create mode 100644 i386/i386at/acpi_parse_apic.c create mode 100644 i386/i386at/acpi_parse_apic.h diff --git a/i386/Makefrag.am b/i386/Makefrag.am index b45378fd..e0ef167a 100644 --- a/i386/Makefrag.am +++ b/i386/Makefrag.am @@ -162,7 +162,9 @@ libkernel_a_SOURCES += \ i386/i386/pit.c \ i386/i386/pit.h \ i386/i386/apic.h \ - i386/i386/apic.c + i386/i386/apic.c \ + i386/i386at/acpi_parse_apic.h \ + i386/i386at/acpi_parse_apic.c endif # diff --git a/i386/i386at/acpi_parse_apic.c b/i386/i386at/acpi_parse_apic.c new file mode 100644 index 00000000..cc299462 --- /dev/null +++ b/i386/i386at/acpi_parse_apic.c @@ -0,0 +1,542 @@ +/* acpi_parse_apic.h - ACPI-MADT table parser. Source file + Copyright (C) 2018 Juan Bosco Garcia + Copyright (C) 2019 2020 Almudena Garcia Jurado-Centurion + Written by Juan Bosco Garcia and Almudena Garcia Jurado-Centurion + + This file is part of Min_SMP. + + Min_SMP is free software; you can redistribute it and/or modify it + under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2, or (at your option) + any later version. + + Min_SMP is distributed in the hope that it will be useful, but + WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, write to the Free Software + Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111, USA. */ + +#include <string.h> /* memcmp, memcpy... */ + +#include <include/stdint.h> /* uint16_t, uint32_t... */ + +#include <mach/machine.h> /* machine_slot */ + +#include <kern/printf.h> /* printf */ +#include <kern/debug.h> +#include <i386/vm_param.h> /* phystokv */ +#include <i386/apic.h> /* lapic, ioapic... */ +#include <i386at/acpi_parse_apic.h> +#include <vm/vm_kern.h> + +static struct acpi_apic *apic_madt = NULL; + +/* + * acpi_print_info: shows by screen the ACPI's rsdp and rsdt virtual address + * and the number of entries stored in RSDT table. + * + * Receives as input the references of RSDP and RSDT tables, + * and the number of entries stored in RSDT. + */ +void +acpi_print_info(struct acpi_rsdp *rsdp, struct acpi_rsdt *rsdt, int acpi_rsdt_n) +{ + + printf("ACPI:\n"); + printf(" rsdp = %x; rsdp->rsdt_addr = %x\n", rsdp, rsdp->rsdt_addr); + printf(" rsdt = %x; rsdt->length = %x (n = %x)\n", rsdt, rsdt->header.length, + acpi_rsdt_n); +} + +/* + * acpi_checksum: calculates the checksum of an ACPI table. + * Receives as input the virtual address of the table. + * + * Returns 0 if success, other value if error. + */ +static uint8_t +acpi_checksum(void *addr, uint32_t length) +{ + uint8_t *bytes = addr; + uint8_t checksum = 0; + unsigned int i; + + /* Sum all bytes of addr */ + for (i = 0; i < length; i++) + checksum += bytes[i]; + + return checksum; +} + +/* + * acpi_check_signature: check if a signature match with the signature of its table. + * + * Receive as parameter both signatures: table signature, the signature which needs to check, + * and real signature, the genuine signature of the table. + * + * Return 0 if success, other if error. + */ + +static int +acpi_check_signature(uint8_t table_signature[], uint8_t real_signature[], uint8_t length) +{ + return memcmp(table_signature, real_signature, length); +} + + +/* + * acpi_check_rsdp: + * check if the RDSP "candidate" table is the real RSDP table. + * + * Compare the table signature with the ACPI signature for this table + * and check is the checksum is correct. + * + * Receives as input the reference of RSDT table. + * + * Preconditions: RSDP pointer must not be NULL. + * + * Returns 0 if correct. + */ +static int8_t +acpi_check_rsdp(struct acpi_rsdp *rsdp) +{ + uint32_t checksum; + int is_rsdp; + + /* Check if rsdp signature match with the ACPI RSDP signature. */ + is_rsdp = acpi_check_signature(rsdp->signature, ACPI_RSDP_SIG, 8*sizeof(uint8_t)); + + if (is_rsdp != ACPI_SUCCESS) + return ACPI_BAD_SIGNATURE; + + /* If match, calculates rdsp checksum and check It. */ + checksum = acpi_checksum(rsdp, sizeof(struct acpi_rsdp)); + + if (checksum != 0) + return ACPI_BAD_CHECKSUM; + + return ACPI_SUCCESS; +} + +/* + * acpi_check_rsdp_align: check if the RSDP address is aligned. + * Preconditions: The address must not be NULL + * + * Returns ACPI_SUCCESS (0) if success, ACPI_BAD_ALIGN if error + */ + +static int8_t +acpi_check_rsdp_align(void *addr) +{ + /* check alignment. */ + if ((uint32_t)addr & (ACPI_RSDP_ALIGN-1)) + return ACPI_BAD_ALIGN; + + return ACPI_SUCCESS; +} + +/* + * acpi_search_rsdp: search the rsdp table in a memory range. + * + * Receives as input the initial virtual address, and the lenght + * of memory range. + * + * Preconditions: The start address (addr) must be aligned. + * + * Returns the reference to rsdp structure if success, NULL if failure. + */ +static struct acpi_rsdp* +acpi_search_rsdp(void *addr, uint32_t length) +{ + void *end; + + /* Search RDSP in memory space between addr and addr+lenght. */ + for (end = addr+length; addr < end; addr += ACPI_RSDP_ALIGN) { + + /* Check if the current memory block stores the RDSP. */ + if ((addr != NULL) && (acpi_check_rsdp(addr) == ACPI_SUCCESS)) { + /* If yes, return RSDP address */ + return (struct acpi_rsdp*) addr; + } + } + + return NULL; +} + +/* + * acpi_get_rsdp: tries to find the RSDP table, + * searching It in many memory ranges, as It's written in ACPI Specification. + * + * Returns the reference to RDSP structure if success, NULL if failure. + */ +struct acpi_rsdp* +acpi_get_rsdp(void) +{ + struct acpi_rsdp *rsdp = NULL; + uint16_t *start = 0x0; + uint32_t base = 0x0; + + /* EDBA start address. */ + start = (uint16_t*) phystokv(0x040e); + base = *start; + + if (base != 0) { /* Memory check. */ + + base <<= 4; /* base = base * 16 */ + + /* check alignment. */ + if (acpi_check_rsdp_align(base) == ACPI_BAD_ALIGN) + return NULL; + + /* Search the RSDP in first 1024 bytes from EDBA. */ + rsdp = acpi_search_rsdp((void*)base,1024); + } + + if (rsdp == NULL) { + /* If RSDP isn't in EDBA, search in the BIOS read-only memory space between 0E0000h and 0FFFFFh */ + rsdp = acpi_search_rsdp((void*) 0x0e0000, 0x100000 - 0x0e0000); + } + + return rsdp; +} + +/* + * acpi_check_rsdt: check if the RSDT initial address is correct + * checking its checksum. + * + * Receives as input a reference for the RSDT "candidate" table. + * Returns 0 if success. + * + * Preconditions: rsdp must not be NULL. + * + */ +static int +acpi_check_rsdt(struct acpi_rsdt *rsdt) +{ + uint8_t checksum; + + checksum = acpi_checksum(rsdt, rsdt->header.length); + + if (checksum != 0) + return ACPI_BAD_CHECKSUM; + + return ACPI_SUCCESS; +} + +/* + * acpi_get_rsdt: Get RSDT table reference from RSDP entries. + * + * Receives as input a reference for RSDP table + * and a reference to store the number of entries of RSDT. + * + * Returns the reference to RSDT table if success, NULL if error. + */ +static struct acpi_rsdt* +acpi_get_rsdt(struct acpi_rsdp *rsdp, int* acpi_rsdt_n) +{ + phys_addr_t rsdt_phys; + struct acpi_rsdt *rsdt = NULL; + int acpi_check; + int signature_check; + + /* Get rsdt address from rsdp table. */ + rsdt_phys = rsdp->rsdt_addr; + rsdt = (struct acpi_rsdt*) kmem_map_aligned_table(rsdt_phys, sizeof(struct acpi_rsdt), VM_PROT_READ); + + /* Check if the RSDT mapping is fine. */ + if (rsdt == NULL) + return NULL; + + /* Check is rsdt signature is equals to ACPI RSDT signature. */ + signature_check = acpi_check_signature(rsdt->header.signature, ACPI_RSDT_SIG, + 4*sizeof(uint8_t)); + + if (signature_check != ACPI_SUCCESS) + return NULL; + + /* Check if rsdt is correct. */ + acpi_check = acpi_check_rsdt(rsdt); + + if (acpi_check != ACPI_SUCCESS) + return NULL; + + /* Calculated number of elements stored in rsdt. */ + *acpi_rsdt_n = (rsdt->header.length - sizeof(rsdt->header)) + / sizeof(rsdt->entry[0]); + + return rsdt; +} + +/* + * acpi_get_apic: get MADT/APIC table from RSDT entries. + * + * Receives as input the RSDT initial address, + * and the number of entries of RSDT table. + * + * Returns a reference to APIC/MADT table if success, NULL if failure. + */ +static struct acpi_apic* +acpi_get_apic(struct acpi_rsdt *rsdt, int acpi_rsdt_n) +{ + struct acpi_dhdr *descr_header; + int check_signature; + + /* Search APIC entries in rsdt table. */ + for (int i = 0; i < acpi_rsdt_n; i++) { + descr_header = (struct acpi_dhdr*) kmem_map_aligned_table(rsdt->entry[i], sizeof(struct acpi_dhdr), + VM_PROT_READ | VM_PROT_WRITE); + + /* Check if the entry contains an APIC. */ + check_signature = acpi_check_signature(descr_header->signature, ACPI_APIC_SIG, 4*sizeof(uint8_t)); + + if (check_signature == ACPI_SUCCESS) { + /* If yes, return the APIC. */ + return (struct acpi_apic*) descr_header; + } + } + + return NULL; +} + +/* + * acpi_add_lapic: add a new Local APIC to cpu_to_lapic array + * and increase the number of cpus. + * + * Receives as input the Local APIC entry in MADT/APIC table. + */ +static void +acpi_apic_add_lapic(struct acpi_apic_lapic *lapic_entry) +{ + /* If cpu flag is correct */ + if (lapic_entry->flags & 0x1) { + /* Add cpu to processors' list. */ + apic_add_cpu(lapic_entry->apic_id); + } + +} + +/* + * apic_add_ioapic: add a new IOAPIC to IOAPICS array + * and increase the number of IOAPIC. + * + * Receives as input the IOAPIC entry in MADT/APIC table. + */ + +static void +acpi_apic_add_ioapic(struct acpi_apic_ioapic *ioapic_entry) +{ + int ret_value = 0; + IoApicData io_apic; + + /* Fill IOAPIC structure with its main fields */ + io_apic.apic_id = ioapic_entry->apic_id; + io_apic.addr = ioapic_entry->addr; + io_apic.base = ioapic_entry->base; + + /* Insert IOAPIC in the list. */ + apic_add_ioapic(io_apic); +} + + +/* + * apic_add_ioapic: add a new IOAPIC to IOAPICS list + * and increase the number of IOAPIC. + * + * Receives as input the IOAPIC entry in MADT/APIC table. + */ + +static void +acpi_apic_add_irq_override(struct acpi_apic_irq_override* irq_override) +{ + IrqOverrideData irq_over; + + /* Fills IRQ override structure with its fields */ + irq_over.bus = irq_override->bus; + irq_over.irq = irq_override->irq; + irq_over.gsi = irq_override->gsi; + irq_over.flags = irq_override->flags; + + /* Insert IRQ override in the list */ + apic_add_irq_override(irq_over); +} + + +/* + * apic_parse_table: parse the MADT/APIC table. + * + * Read the APIC/MADT table entry to entry, + * registering the APIC structures (Local APIC, IOAPIC or IRQ override) entries in their lists. + */ + +static int +acpi_apic_parse_table(struct acpi_apic *apic) +{ + int ret_value = 0; + struct acpi_apic_dhdr *apic_entry = NULL; + uint32_t end = 0; + uint8_t numcpus = 1; + + /* Get the address of first APIC entry */ + apic_entry = (struct acpi_apic_dhdr*) apic->entry; + + /* Get the end address of APIC table */ + end = (uint32_t) apic + apic->header.length; + + /* Initialize number of cpus */ + numcpus = apic_get_numcpus(); + + /* Search in APIC entry. */ + while ((uint32_t)apic_entry < end) { + struct acpi_apic_lapic *lapic_entry; + struct acpi_apic_ioapic *ioapic_entry; + struct acpi_apic_irq_override *irq_override_entry; + + /* Check entry type. */ + switch(apic_entry->type) { + + /* If APIC entry is a CPU's Local APIC. */ + case ACPI_APIC_ENTRY_LAPIC: + if(numcpus < NCPUS) { + /* Store Local APIC data. */ + lapic_entry = (struct acpi_apic_lapic*) apic_entry; + acpi_apic_add_lapic(lapic_entry); + } + break; + + /* If APIC entry is an IOAPIC. */ + case ACPI_APIC_ENTRY_IOAPIC: + + /* Store IOAPIC data. */ + ioapic_entry = (struct acpi_apic_ioapic*) apic_entry; + acpi_apic_add_ioapic(ioapic_entry); + + break; + + /* If APIC entry is a IRQ Override. */ + case ACPI_APIC_ENTRY_IRQ_OVERRIDE: + + /* Store IRQ Override data. */ + irq_override_entry = (struct acpi_apic_irq_override*) apic_entry; + acpi_apic_add_irq_override(irq_override_entry); + break; + + } + + /* Get next APIC entry. */ + apic_entry = (struct acpi_apic_dhdr*)((uint32_t) apic_entry + + apic_entry->length); + + /* Update number of cpus. */ + numcpus = apic_get_numcpus(); + } + + return ACPI_SUCCESS; +} + + +/* + * acpi_apic_setup: parses the APIC/MADT table, to find the Local APIC and IOAPIC structures + * and the common address for Local APIC. + * + * Receives as input a reference for APIC/MADT table. + * Returns 0 if success. + * + * Fills the cpu_to_lapic and ioapics array, indexed by Kernel ID + * with a relationship between Kernel ID and APIC ID, + * and map the Local APIC common address, to fill the lapic reference. + * + * Precondition: The APIC pointer must not be NULL + */ + +static int +acpi_apic_setup(struct acpi_apic *apic) +{ + int apic_checksum; + ApicLocalUnit* lapic; + uint8_t ncpus, nioapics; + int refit = 0; + + /* Check the checksum of the APIC */ + apic_checksum = acpi_checksum(apic, apic->header.length); + + if(apic_checksum != 0) + return ACPI_BAD_CHECKSUM; + + /* map common lapic address */ + lapic = kmem_map_aligned_table(apic->lapic_addr, sizeof(ApicLocalUnit), VM_PROT_READ); + + if (lapic == NULL) + return ACPI_NO_LAPIC; + + apic_lapic_init(lapic); + acpi_apic_parse_table(apic); + + ncpus = apic_get_numcpus(); + nioapics = apic_get_num_ioapics(); + + if (ncpus == 0 || nioapics == 0 || ncpus > NCPUS) + return ACPI_APIC_FAILURE; + + /* Refit the apic-cpu array. */ + refit = apic_refit_cpulist(); + if (refit != -0) + return ACPI_FIT_FAILURE; + + return ACPI_SUCCESS; +} + +/* + * acpi_apic_init: find the MADT/APIC table in ACPI tables + * and parses It to find Local APIC and IOAPIC structures. + * Each Local APIC stores the info and control structores for a cpu. + * The IOAPIC controls the communication of the processors with the I/O devices. + * + * Returns 0 if success, -1 if error. + */ +int +acpi_apic_init(void) +{ + struct acpi_rsdp *rsdp = 0; + struct acpi_rsdt *rsdt = 0; + int acpi_rsdt_n; + int ret_acpi_setup; + int apic_init_success = 0; + + /* Try to get the RSDP pointer. */ + rsdp = acpi_get_rsdp(); + if (rsdp == NULL) + return ACPI_NO_RSDP; + + /* Try to get the RSDT pointer. */ + rsdt = acpi_get_rsdt(rsdp, &acpi_rsdt_n); + if (rsdt == NULL) + return ACPI_NO_RSDT; + + /* Try to get the APIC table pointer. */ + apic_madt = acpi_get_apic(rsdt, acpi_rsdt_n); + if (apic_madt == NULL) + return ACPI_NO_APIC; + + /* Print the ACPI tables addresses. */ + acpi_print_info(rsdp, rsdt, acpi_rsdt_n); + + apic_init_success = apic_data_init(); + if (apic_init_success != ACPI_SUCCESS) + return ACPI_APIC_FAILURE; + + /* + * Starts the parsing of APIC table, to find the APIC structures. + * and enumerate them. This function also find the common Local APIC address. + */ + ret_acpi_setup = acpi_apic_setup(apic_madt); + if (ret_acpi_setup != ACPI_SUCCESS) + return ret_acpi_setup; + + /* Prints a table with the list of each cpu and each IOAPIC with its APIC ID. */ + apic_print_info(); + + return ACPI_SUCCESS; +} diff --git a/i386/i386at/acpi_parse_apic.h b/i386/i386at/acpi_parse_apic.h new file mode 100644 index 00000000..1cfcc9ae --- /dev/null +++ b/i386/i386at/acpi_parse_apic.h @@ -0,0 +1,164 @@ +/* acpi_parse_apic.h - ACPI-MADT table parser. Header file + Copyright (C) 2018 Juan Bosco Garcia + Copyright (C) 2019 2020 Almudena Garcia Jurado-Centurion + Written by Juan Bosco Garcia and Almudena Garcia Jurado-Centurion + + This file is part of Min_SMP. + + Min_SMP is free software; you can redistribute it and/or modify it + under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2, or (at your option) + any later version. + + Min_SMP is distributed in the hope that it will be useful, but + WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, write to the Free Software + Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111, USA. */ + +#ifndef __ACPI_H__ +#define __ACPI_H__ + +#include <include/stdint.h> + +enum ACPI_RETURN { + ACPI_BAD_CHECKSUM = -1, + ACPI_BAD_ALIGN = -2, + ACPI_NO_RSDP = -3, + ACPI_NO_RSDT = -4, + ACPI_BAD_SIGNATURE = -5, + ACPI_NO_APIC = -6, + ACPI_NO_LAPIC = -7, + ACPI_APIC_FAILURE = -8, + ACPI_FIT_FAILURE = -9, + ACPI_SUCCESS = 0, +}; + +#define ACPI_RSDP_ALIGN 16 +#define ACPI_RSDP_SIG "RSD PTR " + +struct acpi_rsdp { + uint8_t signature[8]; + uint8_t checksum; + uint8_t oem_id[6]; + uint8_t revision[1]; + uint32_t rsdt_addr; +} __attribute__((__packed__)); + + +/* + * RSDT Entry Header + * + * Header which stores the descriptors of tables pointed from RDSP's Entry Field + * Includes the signature of the table, to identify each table. + * + * In MADT, the signature is 'APIC'. + */ +struct acpi_dhdr { + uint8_t signature[4]; + uint32_t length; + uint8_t revision; + uint8_t checksum; + uint8_t oem_id[6]; + uint8_t oem_table_id[8]; + uint32_t oem_revision; + uint8_t creator_id[4]; + uint32_t creator_revision; +} __attribute__((__packed__)); + + +#define ACPI_RSDT_SIG "RSDT" + +struct acpi_rsdt { + struct acpi_dhdr header; + uint32_t entry[0]; +} __attribute__((__packed__)); + +/* APIC table signature. */ +#define ACPI_APIC_SIG "APIC" + +/* Types value for MADT entries: Local APIC, IOAPIC and IRQ Override. */ +enum ACPI_APIC_ENTRY_TYPE { + ACPI_APIC_ENTRY_LAPIC = 0, + ACPI_APIC_ENTRY_IOAPIC = 1, + ACPI_APIC_ENTRY_IRQ_OVERRIDE = 2, + ACPI_APIC_ENTRY_NONMASK_IRQ = 4 +}; + +/* + * APIC descriptor header + * Define the type of the structure (Local APIC, I/O APIC or others). + * Type: Local APIC (0), I/O APIC (1). + */ +struct acpi_apic_dhdr { + uint8_t type; + uint8_t length; +} __attribute__((__packed__)); + + +/* + * Multiple APIC Description Table (MADT) + * + * Describes the APIC structures which exist in the machine. + * Includes the common address where Local APIC is mapped in main memory. + * + * Entry field stores the descriptors of APIC structures. + */ +struct acpi_apic { + struct acpi_dhdr header; /* Header, which stores the descriptor for RDST's Entry field. */ + uint32_t lapic_addr; /* Local Interrupt Controller Address. */ + uint32_t flags; + struct acpi_apic_dhdr entry[0]; /* Interrupt Controller Structure */ +} __attribute__((__packed__)); + +/* + * Processor Local APIC Structure + * + * Stores information about APIC ID, flags and ACPI Processor UID + */ + +struct acpi_apic_lapic { + struct acpi_apic_dhdr header; + uint8_t processor_id; /* ACPI Processor UID */ + uint8_t apic_id; + uint32_t flags; +} __attribute__((__packed__)); + + +/* + * I/O APIC Structure + * + * Stores information about APIC ID, and I/O APIC tables + */ + +struct acpi_apic_ioapic { + struct acpi_apic_dhdr header; + uint8_t apic_id; + uint8_t reserved; + uint32_t addr; + uint32_t base; +} __attribute__((__packed__)); + +/* + * IRQ Override structure + * + * Stores information about IRQ override, with busses and IRQ. + */ + +struct acpi_apic_irq_override { + struct acpi_apic_dhdr header; + uint8_t bus; + uint8_t irq; + uint32_t gsi; + uint16_t flags; +} __attribute__((__packed__)); + +int acpi_apic_init(void); +void acpi_print_info(struct acpi_rsdp *rsdp, struct acpi_rsdt *rsdt, int acpi_rsdt_n); + + +#endif /* __ACPI_H__ */ + -- 2.28.0
From 16e597faf63f57ff84d044c9c2893a56d4dfae00 Mon Sep 17 00:00:00 2001 From: Almudena Garcia <liberamenso10...@gmail.com> Date: Tue, 11 Aug 2020 22:12:17 +0200 Subject: [PATCH 2/5] vm_kern: Add kmem_alloc_aligned_table This function allows to map a table in a memory page, using its physical address,aligning the start of the page with the start of the table *vm/vm_kern.c (kmem_alloc_aligned_table): New function. Returns a reference for the virtual address of the table. *vm/vm_kern.h (kmem_alloc_aligned_table): New prototype --- vm/vm_kern.c | 39 +++++++++++++++++++++++++++++++++++++++ vm/vm_kern.h | 2 ++ 2 files changed, 41 insertions(+) diff --git a/vm/vm_kern.c b/vm/vm_kern.c index 2e333ee1..281a045d 100644 --- a/vm/vm_kern.c +++ b/vm/vm_kern.c @@ -635,6 +635,45 @@ retry: return KERN_SUCCESS; } +/* + * kmem_map_aligned_table: map a table or structure in a virtual memory page + * Align the table initial address with the page initial address. + * + * Parameters: + * phys_address: physical address, the start address of the table. + * size: size of the table. + * mode: access mode. VM_PROT_READ for read, VM_PROT_WRITE for write. + * + * Returns a reference to the virtual address if success, NULL if failure. + */ + +void* +kmem_map_aligned_table( + phys_addr_t phys_address, + vm_size_t size, + int mode) +{ + vm_offset_t virt_addr; + kern_return_t ret; + phys_addr_t into_page = phys_address % PAGE_SIZE; + phys_addr_t nearest_page = (uintptr_t)trunc_page(phys_address); + + size += into_page; + + ret = kmem_alloc_wired(kernel_map, &virt_addr, + round_page(size)); + + if (ret != KERN_SUCCESS) + return NULL; + + (void) pmap_map_bd(virt_addr, nearest_page, + nearest_page + round_page(size), mode); + + /* XXX remember mapping somewhere so we can free it? */ + + return (void *) (virt_addr + into_page); +} + /* * kmem_alloc_pageable: * diff --git a/vm/vm_kern.h b/vm/vm_kern.h index 0cdb19db..13115ff9 100644 --- a/vm/vm_kern.h +++ b/vm/vm_kern.h @@ -55,6 +55,8 @@ extern kern_return_t kmem_alloc_pageable(vm_map_t, vm_offset_t *, extern kern_return_t kmem_valloc(vm_map_t, vm_offset_t *, vm_size_t); extern kern_return_t kmem_alloc_wired(vm_map_t, vm_offset_t *, vm_size_t); extern kern_return_t kmem_alloc_aligned(vm_map_t, vm_offset_t *, vm_size_t); +extern void* kmem_map_aligned_table(phys_addr_t, vm_size_t, int); + extern void kmem_free(vm_map_t, vm_offset_t, vm_size_t); extern void kmem_submap(vm_map_t, vm_map_t, vm_offset_t *, -- 2.28.0
From 6596ff60feba9a16748a2b102ef9c32a93ccb6d6 Mon Sep 17 00:00:00 2001 From: Almudena Garcia <liberamenso10...@gmail.com> Date: Tue, 11 Aug 2020 22:26:40 +0200 Subject: [PATCH 4/5] smp: Add generic smp pseudoclass This pseudoclass generalize the initialization and access of SMP data, allowing expands it to other architectures. In x86, the functions calls to apic functions. *kern/smp.c: Source file. Implements a interface to load the SMP functions for the current architecture. *kern/smp.h: Header file. Add declaration for smp_data structure. *i386/i386/smp.c: Source file. Implements a set of functions to manage the SMP actions in i386 *i386/i386/smp.h: Header file. Add declarations for SMP functions in i386. --- Makefrag.am | 3 ++- i386/i386/smp.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++ i386/i386/smp.h | 22 ++++++++++++++++++++ kern/smp.c | 41 +++++++++++++++++++++++++++++++++++++ kern/smp.h | 29 ++++++++++++++++++++++++++ 5 files changed, 148 insertions(+), 1 deletion(-) create mode 100644 i386/i386/smp.c create mode 100644 i386/i386/smp.h create mode 100644 kern/smp.c create mode 100644 kern/smp.h diff --git a/Makefrag.am b/Makefrag.am index ea612275..83d8cf44 100644 --- a/Makefrag.am +++ b/Makefrag.am @@ -121,7 +121,6 @@ EXTRA_DIST += \ ipc/mach_port.srv \ ipc/notify.defs - # # `kernel' implementation (tasks, threads, trivia, etc.). # @@ -199,6 +198,8 @@ libkernel_a_SOURCES += \ kern/sched_prim.c \ kern/sched_prim.h \ kern/shuttle.h \ + kern/smp.h \ + kern/smp.c \ kern/startup.c \ kern/startup.h \ kern/strings.c \ diff --git a/i386/Makefrag.am b/i386/Makefrag.am index e0ef167a..27b9ad72 100644 --- a/i386/Makefrag.am +++ b/i386/Makefrag.am @@ -146,7 +146,9 @@ libkernel_a_SOURCES += \ i386/intel/pmap.c \ i386/intel/pmap.h \ i386/intel/read_fault.c \ - i386/intel/read_fault.h + i386/intel/read_fault.h \ + i386/i386/smp.h \ + i386/i386/smp.c EXTRA_DIST += \ i386/i386/mach_i386.srv diff --git a/i386/i386/smp.c b/i386/i386/smp.c new file mode 100644 index 00000000..09e4bafa --- /dev/null +++ b/i386/i386/smp.c @@ -0,0 +1,54 @@ +/* smp.h - i386 SMP controller for Mach + Copyright (C) 2020 Free Software Foundation, Inc. + Written by Almudena Garcia Jurado-Centurion + + This file is part of GNU Mach. + + GNU Mach is free software; you can redistribute it and/or modify it + under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2, or (at your option) + any later version. + + GNU Mach is distributed in the hope that it will be useful, but + WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, write to the Free Software + Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111, USA. */ + +#include <i386/i386/apic.h> +#include <i386/i386/smp.h> +#include <i386/i386at/acpi_parse_apic.h> + +#include <kern/smp.h> + + +/* + * smp_data_init: initialize smp_data structure + * Must be called after smp_init(), once all APIC structures + * has been initialized + */ +static void smp_data_init(void) +{ + smp_info.num_cpus = apic_get_numcpus(); +} + + +/* + * smp_init: initialize the SMP support, starting the cpus searching + * and enumeration. + */ +int smp_init(void) +{ + int apic_success; + + apic_success = acpi_apic_init(); + if (apic_success) { + smp_data_init(); + } + + return apic_success; +} + diff --git a/i386/i386/smp.h b/i386/i386/smp.h new file mode 100644 index 00000000..a1ed33c9 --- /dev/null +++ b/i386/i386/smp.h @@ -0,0 +1,22 @@ +/* smp.h - i386 SMP controller for Mach. Header file + Copyright (C) 2020 Free Software Foundation, Inc. + Written by Almudena Garcia Jurado-Centurion + + This file is part of GNU Mach. + + GNU Mach is free software; you can redistribute it and/or modify it + under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2, or (at your option) + any later version. + + GNU Mach is distributed in the hope that it will be useful, but + WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, write to the Free Software + Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111, USA. */ + +int smp_init(void); + diff --git a/kern/smp.c b/kern/smp.c new file mode 100644 index 00000000..cfc1a933 --- /dev/null +++ b/kern/smp.c @@ -0,0 +1,41 @@ +/* smp.c - Template for generic SMP controller for Mach. + Copyright (C) 2020 Free Software Foundation, Inc. + Written by Almudena Garcia Jurado-Centurion + + This file is part of GNU Mach. + + GNU Mach is free software; you can redistribute it and/or modify it + under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2, or (at your option) + any later version. + + GNU Mach is distributed in the hope that it will be useful, but + WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, write to the Free Software + Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111, USA. */ + +#include <kern/smp.h> +#include <machine/smp.h> +#include <stdint.h> + +struct smp_data smp_info; + +/* + * smp_get_numcpus: returns the number of cpus existing in the machine + */ +uint8_t smp_get_numcpus(void) +{ + uint8_t numcpus = smp_info.num_cpus; + + if (numcpus == 0) + return 1; /* Although SMP doesn't find cpus, always there are at least one. */ + else + return numcpus; +} + + + diff --git a/kern/smp.h b/kern/smp.h new file mode 100644 index 00000000..fbaee819 --- /dev/null +++ b/kern/smp.h @@ -0,0 +1,29 @@ +/* smp.h - Template for generic SMP controller for Mach. Header file + Copyright (C) 2020 Free Software Foundation, Inc. + Written by Almudena Garcia Jurado-Centurion + + This file is part of GNU Mach. + + GNU Mach is free software; you can redistribute it and/or modify it + under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2, or (at your option) + any later version. + + GNU Mach is distributed in the hope that it will be useful, but + WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, write to the Free Software + Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111, USA. */ + +#include <stdint.h> + +struct smp_data { + int num_cpus; +}; + +extern struct smp_data smp_info; + +uint8_t smp_get_numcpus(void); -- 2.28.0
From d98f4b8e529568070e2a98218b3a747ed1cf9966 Mon Sep 17 00:00:00 2001 From: Almudena Garcia <liberamenso10...@gmail.com> Date: Tue, 11 Aug 2020 22:31:08 +0200 Subject: [PATCH 5/5] model_dep.c: Add smp_init call if NCPUS > 1, call to smp_init to start the search and enumeration of the cpus *i386/i386/model_dep.c (machine_init): add smp_init() call --- i386/i386at/model_dep.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/i386/i386at/model_dep.c b/i386/i386at/model_dep.c index aaeed807..27955d21 100644 --- a/i386/i386at/model_dep.c +++ b/i386/i386at/model_dep.c @@ -42,7 +42,6 @@ #include <mach/machine/multiboot.h> #include <mach/xen.h> -#include <i386/vm_param.h> #include <kern/assert.h> #include <kern/cpu_number.h> #include <kern/debug.h> @@ -50,6 +49,7 @@ #include <kern/macros.h> #include <kern/printf.h> #include <kern/startup.h> +#include <kern/smp.h> #include <sys/time.h> #include <sys/types.h> #include <vm/vm_page.h> @@ -62,6 +62,7 @@ #include <i386/pit.h> #include <i386/pmap.h> #include <i386/proc_reg.h> +#include <i386/vm_param.h> #include <i386/locore.h> #include <i386/model_dep.h> #include <i386at/autoconf.h> @@ -72,6 +73,7 @@ #include <i386at/kd.h> #include <i386at/rtc.h> #include <i386at/model_dep.h> + #ifdef MACH_XEN #include <xen/console.h> #include <xen/store.h> @@ -170,6 +172,14 @@ void machine_init(void) linux_init(); #endif +#if NCPUS > 1 + int smp_success = smp_init(); + + if(smp_success != 0) { + printf("Error in processors detection\n"); + } +#endif /* NCPUS > 1 */ + /* * Find the devices */ -- 2.28.0