On 19 Jul 2020, at 18:06, Almudena Garcia <liberamenso10...@gmail.com> wrote: > > I fixed tabulations and comments style. Now better?
Not hugely. Go read files in the same directory and see if they look like what you've written. Jess > El dom., 19 jul. 2020 a las 18:49, Jessica Clarke (<jrt...@jrtc27.com>) > escribió: > On 19 Jul 2020, at 17:44, Almudena Garcia <liberamenso10...@gmail.com> wrote: > > > > Hi all: > > > > I attach a patch, with the code to find the cpus and enumerate them, > > reading from ACPI tables and MADT (APIC) tables. > > > > I've tested it over Qemu, but I recommends to test It before committing, > > anyway. > > > > You can find the rest of the work in my GitHub repository > > https://github.com/AlmuHS/GNUMach_SMP/tree/smp-new > > > > Check this, and advice me about errors or other necessary fixes > > Before posting patches, please learn to go through and check you've > conformed to the code style, i.e. whitespace, comment styles etc. I see > a huge number of cases where those are not adhered to in your patch at a > glance. Having someone else point out all the issues is a huge waste of > time; better to fix them all yourself and then ask someone to review it > when they're not going to be constantly having to point out sloppiness. > > Jess > > <smp.patch>
