On Tue, 2018-03-27 at 09:20 +0200, Samuel Thibault wrote: > Svante Signell, on mar. 27 mars 2018 02:54:06 +0200, wrote: > > On Tue, 2018-03-27 at 00:50 +0200, Samuel Thibault wrote: > > > Svante Signell, on lun. 26 mars 2018 23:53:31 +0200, wrote: > > > > On Mon, 2018-03-19 at 02:52 +0100, Samuel Thibault wrote: > > > > > Samuel Thibault, on lun. 19 mars 2018 02:51:22 +0100, wrote: > > > > > > - Fixing GNU Coding Style, notably first line of files. > > > > > > > > > > Could people have a look in the libpthread repository? > > > > > Most probably, for a lot of these files, one can just take > > > > > the first > > > > > line of the corresponding nptl file and put "Hurd version". > > > > > > > > Which branch, or master?? > > > > http://git.savannah.gnu.org/cgit/hurd/libpthread.git/ > > > > > > Master, simply. > > > > It would be nice if you could be more explicit next time when > > writing such > > mails. I cannot divine into your thoughts :D > > Well, "master" is the default branch and all other branches are > really > old, I don't see why I couldn't assume that it is obvious that master > would be the one to work on.
Well, Ive looked into the libpthread files and compared with nptl versions, see the attached file. I seems like most nptl files are missing the first line comments not the libpthread (i.e. Hurd) files.
2018-03-31 Add a one-line description to each c-file, according to nptl if needed. nptl code: scp -pr -P5565 localhost:/part1/DEBs/glibc/glibc-2.27/nptl .. git clone git://git.savannah.gnu.org/hurd/libpthread.git pwd /home/srs/Hurd/DEBs/patches/libpthread/libpthread ls *.c forward.c: no first line, nptl/forward.c: no first line libc_pthread_init.c: only in Hurd, no first line lockfile.c: only in Hurd, first line present. (cd pthread;ls -1 *.c) alloca_cutoff.c: first line present nptl/alloca_cutoff.c: first line present cthreads-compat.c: only in Hurd, first line present pt-alloc.c: only in Hurd, first line present pt-cancel.c: first line present nptl/pthread_cancel.c: no first line pt-cleanup.c: first line present nptl/pt-cleanup.c: no first line pt-create.c: first line present nptl/pthread_create.c: no first line pt-dealloc.c: only in Hurd, first line present pt-detach.c: first line present nptl/pthread_detach.c: no first line pt-exit.c: first line present nptl/pthread_exit.c: no first line pt-getattr.c: only in Hurd, first line present pt-initialize.c: only in Hurd, first line present pt-join.c: first line present, nptl/pthread_join.c: no first line pt-self.c: first line present, nptl/pthread_self.c: no first line pt-setcancelstate.c: first line present, nptl/pthread_setcancelstate.c: no first line pt-setcanceltype.c: first line present, nptl/pthread_setcanceltype.c: no first line pt-sigmask.c: first line present, nptl/pthread_sigmask.c: first line present pt-spin-inlines.c: only in Hurd, Move comment after Copyright... to first line?? pt-testcancel.c: first line present, nptl/pthread_testcancel.c: no first line pt-yield.c: first line present, nptl/pthread_yield.c: no firts line
