Subhashish, le Thu 26 Jun 2014 05:34:59 +0530, a écrit : > https://github.com/sprkv5/valgrind-hurd/blob/main/include/vki/vki-scnums-x86-gnu.h > > Is this way proper for the traps to be listed?
Well, we'll see when we actually implement wrappers for them. But at least I don't think you need to keep the mach_trap_function field, since it'll rather be a switch/case over the trap number in the valgrind code. You can however keep the trap names as comments. arg_count might be interesting to keep or not depending on the actual implementation, mach_trap_stack will probably be useful for decoding arguments, mach_trap_unused is clearly not useful :) It does not make sense to use #if MACH_KDB, just assume it's on. The __NR_* shouldn't be references to the table: they're supposed to be the trap numbers, which you'll use for the switch/case, so just use plain 17, 18, etc. Samuel
