On Sun, Nov 10, 2013 at 11:00:26PM +0100, Samuel Thibault wrote: > Marin Ramesa, le Sun 10 Nov 2013 22:50:21 +0100, a écrit : > > Value of node is never read. Simplify the node swap to one assignment > > and remove the temporary variable. > > > > * kern/rbtree.c (rbtree_insert_rebalance): Simplify node swap. > > I'd rather keep it as such, as an expression of the rbtree rotation.
It's not a rotation, merely a variable swap, I would personally simplify it too. FYI, Justus find it too with Clang if I'm right. -- Richard Braun
