Hi, Alle mercoledì 13 giugno 2012, Pino Toscano ha scritto: > Alle martedì 12 giugno 2012, Roland McGrath ha scritto: > > That's almost right, but you should avoid calling > > __mach_port_deallocate if APORT is MACH_PORT_NULL. Also, avoid > > shadowing the local variable ERR with one of the same name in the > > subfunction. > > Hm ok, I saw other cases of shadowing by internal subroutines, and > assumed it was okay (since inside them you want to refer to the local > "err" instead of the outermost one. > > Thanks for the further review, patch attached. > (I would use the non-ChangeLog lines of the patch header as commit > log, would that be okay?)
Ping, about this and the other glibc patches I sent and that are awaiting review. -- Pino Toscano
signature.asc
Description: This is a digitally signed message part.
