On Sat, Jul 17, 2010 at 12:25:48PM +0200, Carl Fredrik Hammar wrote: > Hi, > > On Sat, Jul 17, 2010 at 11:37:34AM +0200, Emilio Pozuelo Monfort wrote: > > + *(int*)*value = user->sock->pipe_class->sock_type; > > + *value_len = sizeof (int); > > + break; > > + default: > > + ret = ENOPROTOOPT; > > + break; > > + } > > + break; > > + default: > > + ret = ENOPROTOOPT; > > Hmm, at this level it probably shouldn't be ENOPROTOOPT since it's not > a protocol option, and since we it could still be a valid protocol level > we can't return EINVAL. Sorry, this was only clear to me once you split > the cases, guess it's back to EOPNOTSUPP here. :-)
Actually, scratch that. As long as it's a valid level it would still be an unsupported option so just leave it as is. Regards, Fredrik