Hi, On Thu, Jun 18, 2009 at 11:14:41PM +0300, Sergiu Ivanov wrote:
> @@ -124,6 +132,13 @@ argp_parse_common_options (int key, char *arg, struct > argp_state *state) > ulfs_match = 0; > break; > > + case OPT_MOUNT: > + /* TODO: Improve the mountee command line parsing mechanism. */ > + err = argz_create_sep (arg, ' ', &mountee_argz, &mountee_argz_len); > + if (err) > + error (EXIT_FAILURE, err, "argz_create_sep"); > + break; > + > case OPT_UNDERLYING: /* --underlying */ > case ARGP_KEY_ARG: > This surely needs some special handling in netfs_append_args() as well?... BTW, what happens if the user specifies multiple --mount options? From the looks of it, it won't blow up completely, but won't really handle it in a useful way either? (A useful way would be either erroring out, or using only the latest option and ignoring the others.) Another case I wonder about is mixing of --mount and "ordinary" arguments -- is it actually possible to do that? You also ignored other bits of my previous feedback: I said you should put the patches actually implementing the union mount functionality *before* the patch that implements the command line handling for using it... -antrik-
