Re: The patch of boot to open a virtual network interface

[Ben Asselstine]

On Tue, Aug 19, 2008 at 4:02 PM, zhengda <[EMAIL PROTECTED]> wrote:
>
> +    case 'f':
> +      dev_file = strstr (arg, "=");
> +      if (dev_file == NULL)
> +       return ARGP_ERR_UNKNOWN;
> +      *dev_file = 0;
> +      add_dev_map (arg, dev_file+1);
> +      break;

I'd feel better about this patch if it used a long option --device
instead of the short option -f.
Also, the use of strstr is pernicious.

Ben