Hi, On Wed, Jun 25, 2008 at 04:44:51PM +0200, zhengda wrote: > Neal H. Walfield wrote:
>> This works in the case where you want to override all pf servers. >> This case is important. Also important is the ability to override a >> single pf server in a similar manner. > I wonder if it's really necessary to override a single pf server. Yes of course. If we want to override the TCP/IP stack, that doesn't mean we want to override the pipe server as well, or the other way round... > server = __file_name_lookup (np, 0, 0); > if (domain <= max_domain) > - servers[domain] = server; > + servers[domain] = server; > + if (name) > + free(name); > } > else > server = servers[domain]; Hm... Something seems wrong with the indentation here -- but it looks as if it has been already wrong in the original code... Can you fix that please? Oh, and of course you still need a changelog entry. There is a section in the GCS on that as well... Otherwise, the patch looks fine to me as it is :-) -antrik-
