Hi Madhusudan, On Thu, Jun 05, 2008 at 02:48:51PM +0530, Madhusudan C.S wrote:
> I have done few commits to be code today. I request you to please > check the code. Well, not being familiar with libnetfs, I unfortunately can't really tell whether the code makes sense. I didn't discover any obvious errors when looking at it -- but then, it's not surprising, considering that most of the code seems to be template code more or less directly copied from some other translator(s) :-) I must again point out that if you copy code, you should mention (below the copyright line) that the code is based on ftpfs (or whatever it is based on), and include the copyright notice from the orignal file. Aside from that, you are not following conventions in the commit messages (which has very adverse effects on some git tools): You should start each commit message with a single line summing up the commit, a blank line, and only then a detailed description what you changed. If you find that you can't sum up the commit in a single line, this most probably means that you have several individual changes, which should actually go into seperate commits... From what I saw, this is often the case. Also, please check the diffs more closely before comitting: In several commits you have changes that aren't mentioned in the commit message, and in fact seem totally unrelated to the rest of the commit... BTW I wonder, why are you keeping build logs in git?... > The major decisions were to use two separate structures for > directory handling, viz. procfs_dir and procfs_dir_entry(This was a > change from my previous thought of using the same structure for all > types of nodes). I can't really comment on that -- I have no idea what these do :-) -antrik-
