----- Original Message -----
From: "Thomas Bushnell BSG" <[EMAIL PROTECTED]>
To: "Barry deFreese" <[EMAIL PROTECTED]>
Cc: <bug-hurd@gnu.org>
Sent: Thursday, November 09, 2006 8:05 PM
Subject: Re: Gnumach Cleanup Round 3 - Move printf.h and add
panicdeclaration
Why the change to add parentheses to printf.c:_doprnt? (If this is to
shut up a gcc warning, then it seems ok, I guess.)
We do not normally put comments on #include's saying why the file was
included for a couple reasons: it very quickly gets out of date, and it
doesn't really communicate anything very important. Such comments
belong in the ChangeLog entry, something like this:
* ddb/db_command.c: Include <kern/debug.h> for panic.
Thomas
Thomas,
Yes it was to shut up a warning but apparently Samuel dropped it from the
patch anyway, so I'll re-add later. As for the comments they are all over
the source, so I did that. I will drop them on a subsequent patch.
Thanks,
Barry
_______________________________________________
Bug-hurd mailing list
Bug-hurd@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-hurd
