On Fri, 2006-01-20 at 05:31 -0500, Thomas Schwinge wrote: > I'm going to commit the following patch unless someone vetoes: > > 2005-11-05 Thomas Schwinge <[EMAIL PROTECTED]>
Just a general comment: If you commit a change, the date in the ChangeLog should be the date of the commit, not the date when the patch was written or submitted. I certainly didn't use to do it, so you will find wrong precedence, but the FSF stated this policy a while ago. > How do people feel about commiting the NIC update patch > (e.g. > <URL:http://svn.debian.org/wsvn/pkg-hurd/gnumach/trunk/debian/patches/11_nic_update.patch?op=file&rev=0&sc=0>; > I can send a inline copy if someone wants to have a look at it.) > > Since all of the current GNU Mach NIC code is imported from third sources > (mostly Linux and Donald Becker's drivers) and that patch is just an > update to those and has been extensively used via the Debian GNU/Hurd > gnumach package, I'd also apply unless there are justified objections. If it got sufficient testing by people who actually such cards (not all cards, just some of them :) then yes, I think it can go in. As a matter of routine, personally I would go and check if the files that are taken from third parties are actually original copies of the versions as stated in the ChangeLog. Thanks, Marcus _______________________________________________ Bug-hurd mailing list Bug-hurd@gnu.org http://lists.gnu.org/mailman/listinfo/bug-hurd
