Samuel Thibault <[EMAIL PROTECTED]> writes: > Samuel Thibault, on sat 05 mar 2005 17:00:32 +0100, wrote: >> here is a patch to extend Marco's console repeater translator > > I made very few corrections (in trans.c:netfs_attempt_mkfile() and > vcs-repeat.c:vcs_read(), namely), latest version is available at > http://perso.ens-lyon.fr/samuel.thibault/patch-console-client
You are checking the return value of alloca. AFAIK alloca can not fail (or better: only silently) so perhaps it is better to either remove this check or use malloc. On IRC we talked about this patch, but no one knew for sure if the lock in netfs_attempt_mkfile was on the right place. Can someone people have a look at this? The patch looks really good to me and I think it should be applied when the copyright is assigned and when there are no further problems. Marcus, what do you think? Thanks, Marco _______________________________________________ Bug-hurd mailing list Bug-hurd@gnu.org http://lists.gnu.org/mailman/listinfo/bug-hurd
