On Tue, Jul 18, 2000 at 09:39:24PM +0200, Marcus Brinkmann wrote:
Marcus, I would like to see a /* FIXME: The line causes bug # xxxx */
added to the patch. It might be nice in case it gets forgotten.
Just my thoughts.
> hi,
>
> (about io-seek and fgetpos failure on ro-stores)
>
> On Thu, Apr 27, 2000 at 04:11:31PM -0400, Roland McGrath wrote:
> > You are both right, it should definitely be done in a cleaner way. Thomas
> > or I will address it when we get the time. It is the case that most uses
> > should call diskfs_check_readonly rather than using the variable.
>
> Is it okay to check in the below workaround until you got around to do it
> proper? The current code is certainly bogus and is the cause of a
> reproducible bug. The below patch just restores the situation as it was
> before the breakage.
>
> Thanks,
> Marcus
>
> 2000-07-18 Marcus Brinkmann <[EMAIL PROTECTED]>
>
> * io-seek.c: Prevent diskfs_check_readonly from having its usual
> effect here, instead doing this with diskfs_readonly.
>
> diff -ru /mnt/marcus/gnu/cvs/hurd/libdiskfs/io-seek.c libdiskfs/io-seek.c
> --- /mnt/marcus/gnu/cvs/hurd/libdiskfs/io-seek.c Thu May 9 20:02:50 1996
> +++ libdiskfs/io-seek.c Wed Apr 26 23:23:12 2000
> @@ -19,7 +19,7 @@
> #include "io_S.h"
> #include <unistd.h>
>
> -#define diskfs_readonly 0
> +#define diskfs_check_readonly() 0
> #define diskfs_synchronous 0
>
> /* Implement io_seek as described in <hurd/io.defs>. */
>
>
> --
> `Rhubarb is no Egyptian god.' Debian http://www.debian.org Check Key server
> Marcus Brinkmann GNU http://www.gnu.org for public PGP Key
> [EMAIL PROTECTED], [EMAIL PROTECTED] PGP Key ID 36E7CD09
> http://homepage.ruhr-uni-bochum.de/Marcus.Brinkmann/ [EMAIL PROTECTED]
--
"It is easy to be blinded to the essential uselessness of computers by
the sense of accomplishment you get from getting them to work at all."
- Douglas Adams
