Control: close -1 On Sat, Aug 17, 2024 at 12:14 AM John SETH Thielemann < [email protected]> wrote:
> To whom it may concern; > > Spent some time chasing a red herring around the'get_suffix' function. > The patch included aims to simplify the logic considerably. > > There are a number of interesting points to note: ... Thanks for looking at this, but the patch can't be applied. get_suffix intentionally returns a pointer into the caller's buffer so callers can modify the name in place. The rewritten version returns a pointer into the static known_suffixes array, breaking every caller. The new matching loop also never examines the filename itself, the .tgz -> .tar logic is deleted, and shorten_name's replacement is a no-op (strnlen after *p='\0'). Closing this report.
