The attached patch fixes two warnings generated by Oracle Developer Studio 12.6
on Solaris 10 sparc. The patch doesn't fix any real bugs and so is not urgent.
All tests pass on this platform.
If the attached patch is installed, we can also remove the "-Wunreachable-code"
line from configure.ac.
>From fa15d3f97bcbcf87fecca55522d54853d0b3010f Mon Sep 17 00:00:00 2001
From: Paul Eggert <egg...@cs.ucla.edu>
Date: Sun, 23 Dec 2018 14:56:53 -0800
Subject: [PATCH] Remove unreachable code
Problem reported by Oracle Developer Studio 12.6.
In the old days we needed a return statement at the end of
the gzip main function to pacify traditional 'lint', but
lint checkers nowadays are smarter.
* gzip.c (main):
* zip.c (file_read): Remove unreachable code.
---
gzip.c | 1 -
zip.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/gzip.c b/gzip.c
index 540e2ff..9751c5e 100644
--- a/gzip.c
+++ b/gzip.c
@@ -679,7 +679,6 @@ int main (int argc, char **argv)
&& errno != EBADF)
write_error ();
do_exit(exit_code);
- return exit_code; /* just to avoid lint warning */
}
/* Return nonzero when at end of file on input. */
diff --git a/zip.c b/zip.c
index 337932c..be5c4b0 100644
--- a/zip.c
+++ b/zip.c
@@ -124,7 +124,6 @@ int file_read(buf, size)
if (len == 0) return (int)len;
if (len == (unsigned)-1) {
read_error();
- return EOF;
}
crc = updcrc((uch*)buf, len);
--
2.19.2
