On Sun, Mar 6, 2016 at 11:19 AM, Paul Eggert <egg...@cs.ucla.edu> wrote:
> Attached is a minor cleanup against the previous patch. I've installed this
> new one too.

Great! Thank you for all the help.
I've pushed one additional patch to accommodate
those with systems where ":" is not the PATH separator:
From ef80dc4ff003105071a6ba7470b30f4ba57e6e8a Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyer...@fb.com>
Date: Sun, 6 Mar 2016 12:27:28 -0800
Subject: [PATCH] tests: port to systems for which ":" is not the PATH
 separator

* Makefile.am (new_path): New variable.
(check-local): Use $(PATH_SEPARATOR) rather than a literal ":",
to avoid "make syntax-check" failure.
---
 Makefile.am | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 8fb17b9..dfed9aa 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -103,18 +103,21 @@ gen-ChangeLog:
 	  mv $(distdir)/cl-t $(distdir)/ChangeLog;			\
 	fi

+# Prepend "." to $PATH:
+new_path = PATH=.$(PATH_SEPARATOR)$$PATH
+
 # A simple test, just of gzip -- more of a sanity check than anything else.
 FILES_TO_CHECK = $(bin_SCRIPTS) \
   $(top_srcdir)/ChangeLog $(top_srcdir)/configure $(top_srcdir)/gzip.c
 check-local: $(FILES_TO_CHECK) $(bin_PROGRAMS) gzip.doc.gz
-	$(AM_V_GEN)PATH=.:$$PATH; { test '$(srcdir)' != . \
-		       || zdiff -c gzip.doc.gz; }
-	$(AM_V_at)PATH=.:$$PATH; zdiff -c $(srcdir)/gzip.doc $(srcdir)/gzip.doc
-	$(AM_V_at)PATH=.:$$PATH; zdiff $(srcdir)/gzip.doc gzip.doc.gz
-	$(AM_V_at)PATH=.:$$PATH; zdiff -c - $(srcdir)/gzip.doc <gzip.doc.gz
-	$(AM_V_at)PATH=.:$$PATH; zdiff -c gzip.doc.gz gzip.doc.gz
-	$(AM_V_at)PATH=.:$$PATH; zgrep -iV >/dev/null
-	$(AM_V_at)PATH=.:$$PATH;			\
+	$(AM_V_GEN)$(new_path); { test '$(srcdir)' != . \
+				    || zdiff -c gzip.doc.gz; }
+	$(AM_V_at)$(new_path); zdiff -c $(srcdir)/gzip.doc $(srcdir)/gzip.doc
+	$(AM_V_at)$(new_path); zdiff $(srcdir)/gzip.doc gzip.doc.gz
+	$(AM_V_at)$(new_path); zdiff -c - $(srcdir)/gzip.doc <gzip.doc.gz
+	$(AM_V_at)$(new_path); zdiff -c gzip.doc.gz gzip.doc.gz
+	$(AM_V_at)$(new_path); zgrep -iV >/dev/null
+	$(AM_V_at)$(new_path);				\
 	for opt in --rsyncable '' -1 -9; do		\
           for file in $(FILES_TO_CHECK); do		\
             gzip $$opt -c -- "$$file"			\
-- 
2.7.2

Reply via email to