Dagobert Michelsen wrote:
> Am 25.01.2010 um 12:59 schrieb Dagobert Michelsen:
>> I have a failing test on Solaris 8 Sparc with Sun Studio 11, all
>> other tests
>> run fine.
>>
>>> ================================
>>> gzip 1.4: ./test-suite.log
>>> ================================
>>>
>>> 1 of 5 tests failed.
>>>
>>> .. contents:: :depth: 2
>>>
>>>
>>> FAIL: tests/zgrep-f (exit: 1)
>>> =============================
>
> Further investigation showed that the problem is a call of the generic
> system-wide
> grep from Solaris in zgrep which doesn't understand several of the
> flags. Replacing
> the invocation with a gnu grep solved the problem:
Thanks for the report and diagnosis.
While changing the zgrep script does indeed solve
your problem, you should consider adjusting your
shell's search patch instead.
If you put /opt/csw/bin in "PATH" before /bin and /usr/bin,
that will solve the problem, too. It has the added benefit
of making your use of "grep" on the command line select the
more featureful version.
>> --- a/zgrep.in
>> +++ b/zgrep.in
>> @@ -26,7 +26,7 @@ case $1 in
>> esac
>> PATH=$bindir:$PATH
>>
>> -grep='${GREP-grep}'
>> +grep='${GREP-/opt/csw/bin/ggrep}'
>>
>> version='zgrep (gzip) @VERSION@
>> Copyright (C) 2007, 2009-2010 Free Software Foundation, Inc.
>
> However, I think it would be nice to detect a grep during configure time
> which knows the flags or let the packager choose a grep to be included
> without patching the source.
There are pros and cons of hard-coding an absolute path to grep in a
script like zgrep. Currently, it seems preferable *not* to hard-code it,
and instead to let the user's PATH select which one to use.
