Hi, thanks for the response.
Ludovic Courtès <[email protected]> writes: > Hey Tomas, > > Tomas Volf <[email protected]> skribis: > >> I think I have found a bug with our git hooks. Output from most >> commands is omitted. >> >> --8<---------------cut here---------------start------------->8--- >> $ git clone https://codeberg.org/guix/guix.git guix-proper >> $ cd guix-proper >> $ git checkout HEAD~ >> $ guix shell -CD guix -- ./bootstrap >> $ guix shell -CD guix -- ./configure >> $ guix shell -CD guix -- make >> $ git pull origin master >> From https://codeberg.org/guix/guix >> * branch master -> FETCH_HEAD >> Updating 67c4836885..5b2fcc51bc >> Fast-forward >> gnu/home/services.scm | 4 +++- >> gnu/packages/kde-sdk.scm | 3 ++- >> 2 files changed, 5 insertions(+), 2 deletions(-) >> guix git: error: unknown introductory commit and signer >> --8<---------------cut here---------------end--------------->8--- >> >> This is not great. Ideally, we would stop modifying local state in >> .git (there are many edge cases), but failing that, this case should be >> handled gracefully. > > Yeah. The instructions suggest running ‘guix git authenticate’ though: > > https://guix.gnu.org/manual/devel/en/html_node/Building-from-Git.html > > Doing this augments ‘.git/config’ such that the error above would not > occur. The suggestion is pretty soft though. It does not mention that it is necessary in order to be able to `git pull' later, it just talks about ensuring authenticity, not basic git functionality. Maybe the wording should be adjusted to actually require that user runs the command? Or even better, adjust the hooks to handle the case gracefully. Tomas -- There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors.
