Hi Ludovic, Ludovic Courtès <l...@gnu.org> writes:
> Maxim Cournoyer <maxim.courno...@gmail.com> skribis: > >> Fixes <https://issues.guix.gnu.org/65924>. >> >> * gnu/packages/version-control.scm (git-minimal) >> [arguments] <imported-modules>: New field. >> <modules>: Augment with (ice-9 match), (ice-9 textual-ports) and (guix >> search-paths). >> <phases>: Add patch-commands phase. >> [inputs]: Add coreutils-minimal and sed. > > [...] > >> + #:imported-modules `(,@%gnu-build-system-modules >> + ,@(source-module-closure '((guix search-paths)))) > > I think we should avoid the dependency on (guix search-paths) here, to > avoid situation such as that described in > <https://issues.guix.gnu.org/66525>. [...] > How about something along these lines instead: > > ;; Instead PATH definition at the top of the file. > (substitute* "git-sh-setup.sh" > (("^unset CDPATH" all) > (string-append "PATH=" (dirname (search-input-file inputs > "bin/basename")) > ":$PATH\nexport PATH\n" all))) > I've done something along these lines with commit ab9a88e355165025f7b4719017c0a40264167b22. Also see bug#66585 for a small doc addition hopefully serving as a reminder to not go down that path again. -- Thanks, Maxim
