Hi, Mathieu Othacehe <othac...@gnu.org> skribis:
>>From f4d2a1bb4df2f65b650be704bffb7ea469ae0232 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe <othac...@gnu.org> > Date: Mon, 31 Oct 2022 13:03:46 +0100 > Subject: [PATCH 1/1] installer: Add core dump support. > > Fixes: <https://issues.guix.gnu.org/58733> > > * gnu/installer.scm (installer-program): Enable core dump generation. > * gnu/installer/dump.scm (%core-dump): New variable. > (prepare-dump): Copy the core dump file. > * gnu/installer/newt/welcome.scm (run-welcome-page): Propose to report an > installation that previously generated a core dump. [...] >>From d3f2ce83152a8ea453b407652dbee7b86a64816b Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe <othac...@gnu.org> > Date: Mon, 31 Oct 2022 16:43:09 +0100 > Subject: [PATCH 1/1] installer: Skip the backtrace page on user abort. > > When the user aborts the installation because a core dump is discovered or the > installation command failed, displaying the abort backtrace doesn't make much > sense. Hide it when the abort condition is &user-abort-error and skip directly > to the dump page. > > * gnu/installer/steps.scm (&user-abort-error): New variable. > (user-abort-error?): New procedure. > * gnu/installer/newt/final.scm (run-install-failed-page): Raise a > user-abort-error. > * gnu/installer/newt/welcome.scm (run-welcome-page): Ditto. > * gnu/installer.scm (installer-program): Hide the backtrace page and directly > propose to dump the report when the a &user-abort-error is raised. Both look reasonable to me, thanks! Now, we should probably focus on Guile-Parted… Thanks, Ludo’.
