Hi,
Today, I tried;
--8<---------------cut here---------------start------------->8---
$ git send-email --to=guix-patc...@gnu.org \
$(./etc/teams.scm cc-members origin/master HEAD) 0000-cover-letter.patch
fatal: ambiguous argument 'some.em...@redacted.com"': unknown revision or path
not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
format-patch -o /tmp/pFSRbRNNoU --add-header="X-Debbugs-Cc: redac...@gmail.com"
--add-header="X-Debbugs-Cc: redacted@email" [...]: command returned error: 128
$ ./etc/teams.scm cc-members origin/master HEAD
--add-header="X-Debbugs-Cc: redacted@email" --add-header="X-Debbugs-Cc:
redacted@email" ...
--8<---------------cut here---------------end--------------->8---
You can see the command fails; this is because when using Bash command
substitution $(), the quotes in the result are not interpreted and are
thus part of the value (literals), which then gets split on white space.
As a quick hacky fix, I tried removing the space and double quotes
like:
modified etc/teams.scm.in
@@ -514,7 +514,7 @@ (define (cc . teams)
"Return arguments for `git send-email' to notify the members of the given
TEAMS when a patch is received by Debbugs."
(format #true
- "~{--add-header=\"X-Debbugs-Cc: ~a\"~^ ~}"
+ "~{--add-header=X-Debbugs-Cc:~a~^ ~}"
(map person-email
(delete-duplicates (append-map team-members teams) equal?))))
and sent a patch with that command:
git send-email --to=guix-patc...@gnu.org \
$(./etc/teams.scm cc-members origin/master HEAD 0000-cover-letter.patch
It created https://issues.guix.gnu.org/58812 with it, but I don't see
any of the X-Debbugs-Cc headers. Mmmh.
--
Thanks,
Maxim
