Hello Maxime, Thanks for your review. I took your comments into account and actually wrote some more patches to clean up start_child of potential thread unsafe practices. Since these are not guix-specific, I sent the whole patchset to guile-devel instead [1].
Maxime Devos <maximede...@telenet.be> writes: > The process opening code looks fragile, so I think some tests are > required to avoid causing regressions later. How would you suggest we do that? Since these are mostly racing issues between threads, I don't know how we could reproduce these reliably in tests. [1] v4 PATCH at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52835 (20220528124634.17353-1-...@jpoiret.xyz) Best, -- Josselin Poiret
