Hi Maxime, ok, I see. Thanks for the explanation. I attached a patch that removes the icons from the source as per your suggestion.
What do you think about this one? Thanks, Roman.
From 5468ef15c239133366314d0d5131e440c2e8893f Mon Sep 17 00:00:00 2001 From: r0man <ro...@burningswell.com> Date: Sat, 19 Mar 2022 15:33:24 +0100 Subject: [PATCH] Remove lsp-treemacs icons from source There's an issue [1] with the icon licenses of the Emacs lsp-treemacs package. This patch removes the icons directory from the sources. [1] https://github.com/emacs-lsp/lsp-treemacs/issues/123 --- gnu/packages/emacs-xyz.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index dcd36291fb..1b6e54ef18 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -24426,6 +24426,8 @@ (define-public emacs-lsp-treemacs (url "https://github.com/emacs-lsp/lsp-treemacs";) (commit version))) (file-name (git-file-name name version)) + (modules '((guix build utils))) + (snippet '(begin (delete-file-recursively "icons") #t)) (sha256 (base32 "05ivqa5900139jzjhwc3nggwznhm8564dz4ydcxym2ddd63571k0")))) (build-system emacs-build-system) -- 2.34.0
Maxime Devos <maximede...@telenet.be> writes: > [[PGP Signed Part:Undecided]] > Roman Scherer schreef op zo 20-03-2022 om 09:59 [+0100]: >> Since the icons are not installed on a Guix system right now, I think >> we can leave the Guix emacs-lsp-treemacs packages as it is for now. >> >> Once upstream has added the licenses for the icons, we could take >> another look and maybe only install the ones that we are allowed to >> include. >> >> What do you think? > > Even though they are not currently installed, I would still remove > them from the 'source', as per (guix)Software Freedom: > >> Some otherwise free upstream package sources contain a small and >> optional subset that violates the above guidelines, for instance >> because this subset is itself non-free code. When that happens, >> the offending items are removed with appropriate patches or code >> snippets in the ‘origin’ form of the package (*note Defining >> Packages::). This way, ‘guix build --source’ returns the “freed” >> source rather than the unmodified upstream source. > > That's about code, not icons, but the same principles apply I'd think. > (Though for some reason, the FSDG makes an exception for things like > images in the section ‘Non-functional Data’?) > > (In this case, the idea icons are likely to be non-free, the netbeans > and eclipse icons are presumabl non-free.) > > Even if the ‘Non-Functional Data’ exception is followed, I think > the source should still remove things that do not seem to follow the > licensing requirements (*) (and hence, might be illegal to > redistribute), to avoid nasty surprises for users doing "guix build -- > sources=transitive foo bar ...". > > (*) TBC, I am not accusing emacs-lsp-treemacs of violating license > terms. Rather, it is not clear to me that it does _not_ violate > licensing terms, and I'd like any potential licensing concerns to be > investigated (and corrected, if necessary) before including the icons > in Guix. > > Greetings, > Maxime. > > [[End of PGP Signed Part]]
signature.asc
Description: PGP signature
