Am Dienstag, den 13.07.2021, 13:25 -0400 schrieb terramor...@cock.li:
> Hi, thank you for the review.
>
> I corrected the version of the package (putty doesn't use
> major.minor.patch, only major.minor), I fixed the lines that were
> over the 80 character limit, re added the check phase, corrected the
> formatting and put in the expat license. However, I do not know what
> you mean by the "ChangeLog part of the commit message", I thought
> that standalone patch didn't have a commit message attached.
> Could you elaborate?
>
> Here is the modified patch.
Please don't send raw diffs and more importantly don't copypaste them
into your mail client (unless you know exactly, that your mail client
behaves in a correct manner, which most don't). Mail clients have a
tendency to mess up whitespace and line lengths, which can and does
break diffs. Instead, use `git format-patch` and attach the generated
patch file or (the following way is preferred) use `git send-email`.
When using format-patch/send-email, the full commit message and
name/email of the committer will be transmitted as well, not just a raw
diff.
Your second patch LGTM, perhaps with a few fixable formatting stuffs,
but I'll have to ask you to resend it, since I can't `git am` it.
Thanks,
Leo
> diff --git a/gnu/packages/networking.scm
> b/gnu/packages/networking.scm
> index 19b58501e9..ce00a016e6 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -4100,3 +4100,38 @@ on hub/switched networks. It is based on
> @acronym{ARP} packets, it will send
> @acronym{ARP} requests and sniff for replies.")
> (home-page "https://github.com/netdiscover-scanner/netdiscover";)
> (license license:gpl3+)))
> +
> +(define-public putty
> + (package
> + (name "putty")
> + (version "0.75")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "http://www.putty.be/"; version
> + "/putty-" version ".tar.gz"))
> + (sha256
> + (base32
> "1xgrr1fbirw79zafspg2b6crzfmlfw910y79md4r7gnxgq1kn5yk"))))
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-before 'configure 'go-into-unix/
> + (lambda _ (begin
> + (chdir "unix")
> + #t))))))
> + (build-system gnu-build-system)
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (inputs
> + `(("gtk+" ,gtk+)
> + ("perl" ,perl)
> + ("python" ,python)
> + ("python2" ,python-2.7)))
> + (synopsis "Graphical @acronym{SSH} and telnet client")
> + (description
> + "Putty is a powerful terminal client. It supports
> @acronym{SSH},
> telnet,
> +and raw socket connections with good terminal emulation. It
> supports
> public key
> +authentication and Kerberos single-sign-on. It also includes
> command-line
> +@acronym{SFTP} and @acronym{SCP} implementations.")
> + (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/";
> )
> + (license license:expat)))
