Hi, Brendan Tildesley <bt...@mailbox.org> skribis:
>> On 04/14/2021 12:32 PM Ludovic Courtès <l...@gnu.org> wrote: [...] >> The patch Brendan posted LGTM (though I’m surprised the directory itself >> can have the right UID/GID while files inside it don’t; perhaps this was >> made possible by 2161820ebbbab62a5ce76c9101ebaec54dc61586, which chowns >> the home directory unconditionally.) >> >> Note that there are other places, in addition to GDM, where we >> forcefully reset the UID/GID of the home directory (e.g., for the >> ‘knot-resolver’ service.) >> >> My preferred solution to this would be to unconditionally chown -R home >> directories upon activation (for efficiency, it would be best if we >> could do that if and only if the home directory itself has wrong >> ownership). Thoughts? >> > I'm confused. It sounds like you're suggesting to add the very IF condition > that my > patch removes from %gdm-activation in order to fix the problem. I’d like to understand why the ‘if’ the patch removes was problematic. I think it relates to the commit above, but that needs more investigation. Ludo’.