Hi again! Ludovic Courtès <l...@gnu.org> writes:
> Hi, > > Maxim Cournoyer <maxim.courno...@gmail.com> skribis: > >>> Thanks for the patch, that should break the deadlock and allow us to >>> proceed with the release! >>> >>> Next we need to update the ‘release’ target so >>> GUIX_ALLOW_ME_TO_USE_PRIVATE_COMMIT is set. >> >> Done! > > Thanks! > >>> the extra dependency on Git, >> >> To me, this script (update-guix-package), is an extension of the >> Make-based build system (that's currently it's sole entry-point). There >> are already calls to git in this build system (for example, to get the >> commit corresponding to HEAD), so I don't perceive it as nasty in this >> context. It can also be used as a reminder of things that are missing >> in (guile git), for the purists ;-). > > I think we had everything needed in Guile-Git. Not for the current implementation, that uses git worktrees and search for the presence of the commit corresponding to HEAD in the upstream remote. If my (summary) analysis of the current state of (guile git) is wrong, I'd be happy to migrate the bits shelling out to git to actual library calls via (guile git). [...] > I hope this discussion can at least help improve mutual understanding on > future patches and review processes. > > Thanks again for your time and patience! I am equally grateful for yours. This is a long thread! Thanks, Maxim
